Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README example code is outdated #211

Closed
tv42 opened this issue May 20, 2021 · 1 comment · Fixed by #314
Closed

README example code is outdated #211

tv42 opened this issue May 20, 2021 · 1 comment · Fixed by #314

Comments

@tv42
Copy link

tv42 commented May 20, 2021

"How it Works" example has

#[macro_use]
extern crate derive_builder;

which is old style Rust and not very recognizable/usable to newbies (https://doc.rust-lang.org/edition-guide/rust-2018/module-system/path-clarity.html).

Below it, "Get Started" says "Add use derive_builder::Builder;", which is the new style.

@TedDriggs
Copy link
Collaborator

This relates to #231; I think we want to move all the tests and examples to the new style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants