Skip to content

Commit 11572f6

Browse files
committed
Clean up some todos/comments
1 parent 9280245 commit 11572f6

File tree

3 files changed

+2
-9
lines changed

3 files changed

+2
-9
lines changed

src/components/search/grid/SearchResultGrid.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ const GRID_COLUMN_SET = 'grid';
1818
const cardPropTypes = {
1919
result: PropTypes.instanceOf(Immutable.Map),
2020
index: PropTypes.number,
21+
listType: PropTypes.string,
2122
titleFields: PropTypes.array,
2223
subtitleFields: PropTypes.array,
2324
searchDescriptor: PropTypes.object,
@@ -41,7 +42,6 @@ export function SearchResultCard({
4142
location = getItemLocationPath(result, { config, searchDescriptor });
4243
}
4344

44-
// todo: read fields from record config
4545
// todo: loading image
4646
return (
4747
<div style={{ paddingBottom: '10px' }}>

src/components/search/list/SearchList.jsx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ const DETAIL_COLUMN_SET = 'list';
1919

2020
const itemPropTypes = {
2121
item: PropTypes.instanceOf(Immutable.Map),
22-
// exact shape tbd
2322
index: PropTypes.number,
2423
listItems: PropTypes.array,
2524
// render context like search table? or a better way to handle all this?
@@ -116,8 +115,6 @@ function SearchDetailList({ searchDescriptor, intl, listType = 'search' }) {
116115

117116
// Note: The items returned is an Immutable.Map, so we need to use get
118117
// in order to retrieve the data
119-
// Note x2: This is only available for 'new' searches, so we don't need a list type prop
120-
// todo: read into the search results based on the list type
121118
// todo: why do we need to do !results AND !items?
122119
const items = readListItems(config, listType, results);
123120
if (!items) {

src/components/search/table/SearchTable.jsx

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -92,10 +92,8 @@ function getSortDir(searchDescriptor) {
9292
* to be displayed.
9393
*
9494
* todo: parity with other search result table
95-
* - row data formatting
96-
* - sorting
97-
* - checkboxes actually working
9895
* - aria-labels + general wcag compliance
96+
* - figure out hrefs
9997
* - ???
10098
*/
10199
function SearchResultTable({ searchDescriptor, listType = 'common', intl }) {
@@ -113,7 +111,6 @@ function SearchResultTable({ searchDescriptor, listType = 'common', intl }) {
113111

114112
// Note: The items returned is an Immutable.Map, so we need to use get
115113
// in order to retrieve the data
116-
// todo: read into the search results based on the list type
117114
// todo: why do we need to do !results AND !items?
118115
const items = readListItems(config, listType, results);
119116
if (!items) {
@@ -129,7 +126,6 @@ function SearchResultTable({ searchDescriptor, listType = 'common', intl }) {
129126
// read headers
130127
const columnConfig = getColumnConfig(config, searchDescriptor, 'default');
131128

132-
// console.log(`column config: ${JSON.stringify(columnConfig)}`);
133129
// todo: dataKey is for ucb support. basically it allows multiple fields to be used
134130
// in the event one is missing. See cspace-ui-plugin-profile-pahma.js
135131
const columns = Object.keys(columnConfig)

0 commit comments

Comments
 (0)