DRYD-1885: Error Handling > Placeholders displayed in error message when user does not have permission to create relationships (#303)

Author: spirosdi

docs/configuration/messages.js

@@ -8300,9 +8300,9 @@ export default {
 
   "searchToRelateModal.error.locked": "Locked records are selected. Relations cannot be made to locked records.",
 
-  "searchToRelateModal.error.notPermitted": "{name} records are selected. You are not permitted to create relations to {collectionName}.",
+  "searchToRelateModal.error.notPermitted": "{selectedCount, plural, one {{name} record is} other {{name} records are}} selected. You are not permitted to create relations to {collectionName}.",
 
-  "searchToRelateModal.errorTitle": "Can't Relate",
+  "searchToRelateModal.errorTitle": "Permission Denied",
 
   "searchToRelateModal.label": "Relate records",
 
@@ -8711,4 +8711,4 @@ export default {
   "workflowStateIcon.locked": "Locked",
 
   "workflowStateIcon.replicated": "Replicated",
-}
+}

src/components/search/RelateResults.jsx

@@ -68,6 +68,7 @@ export default function RelateResults({
           err = {
             code: 'notPermitted',
             values: {
+              selectedCount: selectedItems.size,
               name: <FormattedMessage {...recordMessages.name} />,
               collectionName: <FormattedMessage {...recordMessages.collectionName} />,
             },

src/components/search/SearchToRelateModal.jsx

@@ -30,7 +30,7 @@ const messages = defineMessages({
   },
   errorTitle: {
     id: 'searchToRelateModal.errorTitle',
-    defaultMessage: 'Can\'t Relate',
+    defaultMessage: 'Permission Denied',
   },
 });
 
@@ -41,7 +41,7 @@ const errorMessages = defineMessages({
   },
   notPermitted: {
     id: 'searchToRelateModal.error.notPermitted',
-    defaultMessage: '{name} records are selected. You are not permitted to create relations to {collectionName}.',
+    defaultMessage: '{selectedCount, plural, one {{name} record is} other {{name} records are}} selected. You are not permitted to create relations to {collectionName}.',
   },
 });
 
@@ -55,6 +55,7 @@ const propTypes = {
   }),
   error: PropTypes.shape({
     code: PropTypes.string,
+    values: PropTypes.object,
   }),
   isOpen: PropTypes.bool,
   perms: PropTypes.instanceOf(Immutable.Map),
@@ -179,7 +180,7 @@ export default class SearchToRelateModal extends Component {
           onAcceptButtonClick={onCancelButtonClick}
           onCloseButtonClick={onCloseButtonClick}
         >
-          <FormattedMessage {...errorMessages[error.code]} />
+          <FormattedMessage {...errorMessages[error.code]} values={error.values || {}} />
         </Modal>
       );
     }

test/specs/components/search/SearchToRelateModal.spec.jsx

@@ -363,4 +363,32 @@ describe('SearchToRelateModal', () => {
 
     message.props.defaultMessage.should.contain('Locked records are selected');
   });
+
+  it('should render a Modal containing an error message with the error.values being passed', () => {
+    const error = {
+      code: 'notPermitted',
+      values: {
+        selectedCount: 3,
+        name: 'Object record',
+        collectionName: 'Objects',
+      },
+    };
+
+    const shallowRenderer = createRenderer();
+
+    shallowRenderer.render(
+      <SearchToRelateModal
+        isOpen
+        error={error}
+      />,
+    );
+
+    const result = shallowRenderer.getRenderOutput();
+
+    result.type.should.equal(Modal);
+
+    const message = findWithType(result, FormattedMessage);
+
+    message.props.values.should.equal(error.values);
+  });
 });