wip

Author: theobat

hie.yaml

@@ -0,0 +1,4 @@
+cradle:
+  stack:
+    - path: "."
+      component: "stack:lib"

src/Stack/Build/ConstructPlan.hs

@@ -43,6 +43,7 @@ import           Stack.Types.Compiler
 import           Stack.Types.Config
 import           Stack.Types.GhcPkgId
 import           Stack.Types.NamedComponent
+import           Stack.Types.PackageComponent (libraryPackage)
 import           Stack.Types.Package
 import           Stack.Types.SourceMap
 import           Stack.Types.Version
@@ -200,7 +201,7 @@ constructPlan baseConfigOpts0 localDumpPkgs loadPackage0 sourceMap installedMap
         then do
             let toTask (_, ADRFound _ _) = Nothing
                 toTask (name, ADRToInstall task) = Just (name, task)
-                tasks = M.fromList $ mapMaybe toTask adrs
+                tasks = first libraryPackage $ M.fromList $ mapMaybe toTask adrs
                 takeSubset =
                     case boptsCLIBuildSubset $ bcoBuildOptsCLI baseConfigOpts0 of
                         BSAll -> pure

src/Stack/Build/Execute.hs

@@ -82,6 +82,7 @@ import           Stack.Types.Compiler
 import           Stack.Types.Config
 import           Stack.Types.GhcPkgId
 import           Stack.Types.NamedComponent
+import           Stack.Types.PackageComponent (forgetComponentName, PackageComponentName, getPackageNameLength)
 import           Stack.Types.Package
 import           Stack.Types.Version
 import qualified System.Directory as D
@@ -500,7 +501,7 @@ executePlan boptsCli baseConfigOpts locals globalPackages snapshotPackages local
   where
     mlargestPackageName =
       Set.lookupMax $
-      Set.map (length . packageNameString) $
+      Set.map getPackageNameLength $
       Map.keysSet (planTasks plan) <> Map.keysSet (planFinals plan)
 
 copyExecutables
@@ -647,7 +648,7 @@ executePlan' installedMap0 targets plan ee@ExecuteEnv {..} = do
         when (boptsOpenHaddocks eeBuildOpts) $ do
             let planPkgs, localPkgs, installedPkgs, availablePkgs
                     :: Map PackageName (PackageIdentifier, InstallLocation)
-                planPkgs = Map.map (taskProvides &&& taskLocation) (planTasks plan)
+                planPkgs = Map.mapKeys forgetComponentName $ Map.map (taskProvides &&& taskLocation) (planTasks plan)
                 localPkgs =
                     Map.fromList
                         [(packageName p, (packageIdentifier p, Local)) | p <- map lpPackage eeLocals]

src/Stack/Types/Build.hs

@@ -70,6 +70,7 @@ import           Stack.Types.Config
 import           Stack.Types.GhcPkgId
 import           Stack.Types.NamedComponent
 import           Stack.Types.Package
+import           Stack.Types.PackageComponent (PackageComponentName)
 import           Stack.Types.Version
 import           System.FilePath                 (pathSeparator)
 import           RIO.Process                     (showProcessArgDebug)
@@ -513,8 +514,8 @@ installLocationIsMutable Local = Mutable
 
 -- | A complete plan of what needs to be built and how to do it
 data Plan = Plan
-    { planTasks :: !(Map PackageName Task)
-    , planFinals :: !(Map PackageName Task)
+    { planTasks :: !(Map PackageComponentName Task)
+    , planFinals :: !(Map PackageComponentName Task)
     -- ^ Final actions to be taken (test, benchmark, etc)
     , planUnregisterLocal :: !(Map GhcPkgId (PackageIdentifier, Text))
     -- ^ Text is reason we're unregistering, for display only

src/Stack/Types/NamedComponent.hs

@@ -22,12 +22,20 @@ import qualified Data.Set as Set
 import qualified Data.Text as T
 
 -- | A single, fully resolved component of a package
+-- This type is Cabal based, and follows the .cabal files
+-- possibilities.
+-- These options are build targets.
 data NamedComponent
     = CLib
+    -- ^ The default library in a haskell project.
     | CInternalLib !Text
+    -- ^ An optional (named) internal library.
     | CExe !Text
+    -- ^ An executable.
     | CTest !Text
+    -- ^ A test target.
     | CBench !Text
+    -- ^ A benchmark target.
     deriving (Show, Eq, Ord)
 
 renderComponent :: NamedComponent -> Text

src/Stack/Types/PackageComponent.hs

@@ -0,0 +1,39 @@
+{-# LANGUAGE NoImplicitPrelude #-}
+{-# LANGUAGE DeriveFunctor #-}
+{-# LANGUAGE DeriveGeneric #-}
+{-# LANGUAGE DeriveDataTypeable #-}
+{-# LANGUAGE GeneralizedNewtypeDeriving #-}
+{-# LANGUAGE OverloadedStrings #-}
+{-# LANGUAGE RankNTypes #-}
+{-# LANGUAGE FlexibleContexts #-}
+{-# LANGUAGE DataKinds #-}
+{-# LANGUAGE ConstraintKinds #-}
+
+module Stack.Types.PackageComponent where
+
+import Stack.Prelude
+import Stack.Types.NamedComponent (NamedComponent(CLib))
+
+-- | Required for component-addressed build plans.
+-- Before introducing this, most packages were 'PackageName' addressed.
+-- See <https://github.com/commercialhaskell/stack/issues/4745 this issue>
+-- for more details.
+data PackageComponentName = PackageComponentName {
+  packageName :: !PackageName,
+  componentName :: !NamedComponent
+} deriving (Eq, Show, Ord)
+
+-- | This is needed for computing the largest packageName length in a BuildPlan.
+-- See <../Build/Execute.hs#504 this file>
+getPackageNameLength :: PackageComponentName -> Int
+getPackageNameLength PackageComponentName{packageName=pn} = length . packageNameString $ pn
+
+-- | This is the main case for most packages, you only depend on their default library.
+libraryPackage :: PackageName -> PackageComponentName
+libraryPackage pckName = PackageComponentName {
+    packageName = pckName,
+    componentName = CLib
+  }
+
+forgetComponentName :: PackageComponentName -> PackageName
+forgetComponentName = packageName

stack.cabal

@@ -218,6 +218,7 @@ library
   other-modules:
       Path.Extended
       Stack.Types.Cache
+      Stack.Types.PackageComponent
   autogen-modules:
       Paths_stack
   hs-source-dirs:

stack.code-workspace

@@ -0,0 +1,7 @@
+{
+	"folders": [
+		{
+			"path": "."
+		}
+	]
+}