Skip to content

Commit 3129cd6

Browse files
committed
refactor(conventional-commits): remove string.Template usage as jinja2 is standard dependency
1 parent 6412695 commit 3129cd6

File tree

1 file changed

+4
-13
lines changed

1 file changed

+4
-13
lines changed

commitizen/cz/conventional_commits/conventional_commits.py

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,15 @@
11
import os
22
from collections.abc import Iterable
3-
from typing import TYPE_CHECKING, TypedDict
3+
from typing import TypedDict
4+
5+
from jinja2 import Template
46

57
from commitizen import defaults
68
from commitizen.config import BaseConfig
79
from commitizen.cz.base import BaseCommitizen
810
from commitizen.cz.utils import multiple_line_breaker, required_validator
911
from commitizen.question import CzQuestion
1012

11-
if TYPE_CHECKING:
12-
from jinja2 import Template
13-
else:
14-
try:
15-
from jinja2 import Template
16-
except ImportError:
17-
from string import Template
18-
1913
__all__ = ["ConventionalCommitsCz"]
2014

2115

@@ -181,10 +175,7 @@ def questions(self) -> Iterable[CzQuestion]:
181175

182176
def message(self, answers: ConventionalCommitsAnswers) -> str: # type: ignore[override]
183177
if _message_template := self.custom_settings.get("message_template"):
184-
message_template = Template(_message_template)
185-
if getattr(Template, "substitute", None):
186-
return message_template.substitute(**answers) # type: ignore[attr-defined,no-any-return] # pragma: no cover # TODO: check if we can fix this
187-
return message_template.render(**answers)
178+
return Template(_message_template).render(**answers)
188179

189180
prefix = answers["prefix"]
190181
scope = answers["scope"]

0 commit comments

Comments
 (0)