Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changedetectio.io - Request to fix Width And Height definition #883

Closed
1 of 2 tasks
Lockie85 opened this issue Dec 17, 2024 · 4 comments
Closed
1 of 2 tasks

Changedetectio.io - Request to fix Width And Height definition #883

Lockie85 opened this issue Dec 17, 2024 · 4 comments
Labels
not a script issue This is not a script issue wontdo This will not be worked on

Comments

@Lockie85
Copy link

βœ… Have you read and understood the above guidelines?

yes

πŸ“œ What is the name of the script you are using?

Change Detection LXC

πŸ“‚ What was the exact command used to execute the script?

bash -c "$(wget -qLO - https://github.com/community-scripts/ProxmoxVE/raw/main/ct/changedetection.sh)"

πŸ“ Provide a clear and concise description of the issue.

The script isn't up to date with latest guidance which enables the resolution to be set for playwright, see here for details:
dgtlmoon/changedetection.io#2739 (comment)

βš™οΈ What settings are you using?

  • Default Settings
  • Advanced Settings

πŸ–₯️ Which Linux distribution are you using?

Debian 12

πŸ”„ Steps to reproduce the issue.

  1. Install the script with default settings.
  2. Within Changedetection.io "Add a new change detection watch" e.g. "https://store.steampowered.com/" and select "Edit > Watch"
  3. Select tab "Request"
  4. Select "Fetch Method" > "Playwright Chromium/Javascript via 'ws://localhost:3000/chrome?launch={defaultViewport:{height:720,width:1280},headless:false,stealth:true}&blockAds=true'"
  5. Select "Save"
  6. Wait for the site to process
  7. Select "Edit" on the site
  8. Select "Visual Filter Selector"
  9. Notice the issue, the resolution is to small for the site and adjusting the current settings within "changedetection.service" does not work.

❌ Paste the full error output (if available).

No error

πŸ–ΌοΈ Additional context (optional).

No response

@michelroegl-brunner
Copy link
Member

Do you have the changes we can make on hand? In the linked disccusion i can see no solution for this problem.

@michelroegl-brunner michelroegl-brunner added the question Further information is requested label Dec 18, 2024
@Lockie85
Copy link
Author

Do you have the changes we can make on hand? In the linked discussion I can see no solution for this problem.

I don't have the exact changes required to be implemented to resolve the issue no. Only a direction which I don't understand how to execute.

Firstly I believe you can no longer use this:
PLAYWRIGHT_DRIVER_URL=ws://localhost:3000
Instead you need to use this:
PLAYWRIGHT_DRIVER_URL=ws://sockpuppetbrowser:3000

There might be more knock-ons from that, I don't know but this is what I understand so far.

Potentially this page provides the correct guidance...
https://github.com/dgtlmoon/changedetection.io/wiki/Playwright-content-fetcher

@reikolydia
Copy link

Instead you need to use this: PLAYWRIGHT_DRIVER_URL=ws://sockpuppetbrowser:3000

Where does it state that? what does sockpuppetbrowser actually resolve to? i'd prefer an ip address instead of a hostname

@michelroegl-brunner michelroegl-brunner added not a script issue This is not a script issue wontdo This will not be worked on and removed question Further information is requested labels Jan 22, 2025
@michelroegl-brunner
Copy link
Member

I can not find a solution for this. This is not an initial problem from our script. We can not support each individual app. When you find a solution open a pr to fix it or a disscussion.

@michelroegl-brunner michelroegl-brunner closed this as not planned Won't fix, can't repro, duplicate, stale Jan 22, 2025
@community-scripts community-scripts locked and limited conversation to collaborators Jan 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
not a script issue This is not a script issue wontdo This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants