Replace all BetterCodex app icon resources

Author: advaitpaliwal

STATUS.md

@@ -111,6 +111,7 @@ Current marketplace architecture update:
 - `Focus Contrast` was removed from the local sample catalog and pushed out of the community registry in `companion-inc/bettercodex-plugins` commit `93de654`, leaving zero desktop plugin packages in the hosted marketplace source.
 - `/Applications/BetterCodex.app` was refreshed with `npm run desktop -- install --launch=false`; bundle id remains `com.openai.codex.bettercodex`.
 - Current installed-app verification after the icon refresh: `/Applications/BetterCodex.app` has loader `yes`, repair agent `no`, ASAR integrity `yes`, codesign `yes`, and `CFBundleIconFile` is `bettercodex.icns`.
+- BetterCodex icon install now overwrites the sibling app's legacy icon resources as well as `bettercodex.icns`: `icon.icns`, `electron.icns`, `app.icns`, `icon.png`, `icon-codex-dark-color.png`, `icon-codex-light.png`, and `default_app/icon.png` all point to the gradient BetterCodex asset in `/Applications/BetterCodex.app`; Launch Services was re-registered, Quick Look cache reset, Dock restarted, and the app relaunched.
 - Official `/Applications/Codex.app` stayed clean after the BetterCodex icon/install refresh: loader `no`, repair agent `no`, ASAR integrity `yes`, and codesign `yes`.
 - Live `https://bettercodex-web.companion-inc.workers.dev/api/addons` returned schema version `1`, zero add-ons, and `Focus Contrast` absent after the registry cleanup.
 - Disposable CDP smoke against `/tmp/Codex-BetterCodex-MarketplaceSmoke.app` verified top-level tabs `Plugins`/`Themes`, no `Skills`/`Store` text inside BetterCodex, Marketplace under both active surfaces, `Example Theme` install from Themes Marketplace, and local file write to `/tmp/bettercodex-marketplace-smoke-home/themes/example.theme.css`.

apps/desktop/src/bundler.js

@@ -153,6 +153,19 @@ function installBetterCodexIcon(destination) {
     childProcess.execFileSync("/usr/bin/iconutil", ["-c", "icns", iconset, "-o", iconPath], {
       stdio: "inherit",
     });
+    for (const filename of ["icon.icns", "electron.icns", "app.icns"]) {
+      fs.copyFileSync(iconPath, path.join(resourcesDir, filename));
+    }
+    for (const filename of ["icon.png", "icon-codex-dark-color.png", "icon-codex-light.png"]) {
+      const target = path.join(resourcesDir, filename);
+      if (fs.existsSync(target)) {
+        fs.copyFileSync(source, target);
+      }
+    }
+    const defaultAppIcon = path.join(resourcesDir, "default_app", "icon.png");
+    if (fs.existsSync(defaultAppIcon)) {
+      fs.copyFileSync(source, defaultAppIcon);
+    }
     return fs.existsSync(iconPath);
   } catch (error) {
     console.warn(`BetterCodex icon generation skipped: ${error.message}`);