review comments

Author: aaronj0

lib/CppInterOp/Compatibility.h

@@ -31,6 +31,34 @@ static inline char* GetEnv(const char* Var_Name) {
 #endif
 }
 
+//  Runtime symbols required if the library using JIT (Cpp::Evaluate) does not
+//  link to llvm
+#if !defined(CPPINTEROP_USE_CLING) && !defined(EMSCRIPTEN)
+struct __clang_Interpreter_NewTag {
+} __ci_newtag;
+#if CLANG_VERSION_MAJOR >= 22
+extern "C" void* __clang_Interpreter_SetValueWithAlloc(void* This, void* OutVal,
+                                                       void* OpaqueType)
+#else
+void* __clang_Interpreter_SetValueWithAlloc(void* This, void* OutVal,
+                                            void* OpaqueType);
+#endif
+
+#if CLANG_VERSION_MAJOR > 18
+    extern "C" void __clang_Interpreter_SetValueNoAlloc(void* This,
+                                                        void* OutVal,
+                                                        void* OpaqueType, ...);
+#else
+void __clang_Interpreter_SetValueNoAlloc(void*, void*, void*);
+void __clang_Interpreter_SetValueNoAlloc(void*, void*, void*, void*);
+void __clang_Interpreter_SetValueNoAlloc(void*, void*, void*, float);
+void __clang_Interpreter_SetValueNoAlloc(void*, void*, void*, double);
+void __clang_Interpreter_SetValueNoAlloc(void*, void*, void*, long double);
+void __clang_Interpreter_SetValueNoAlloc(void*, void*, void*,
+                                         unsigned long long);
+#endif
+#endif // CPPINTEROP_USE_CLING
+
 #if CLANG_VERSION_MAJOR < 19
 #define Template_Deduction_Result Sema::TemplateDeductionResult
 #define Template_Deduction_Result_Success                                      \

lib/CppInterOp/CppInterOp.cpp

@@ -90,34 +90,6 @@
 #include <unistd.h>
 #endif // WIN32
 
-//  Runtime symbols required if the library using JIT (Cpp::Evaluate) does not
-//  link to llvm
-#if !defined(CPPINTEROP_USE_CLING) && !defined(EMSCRIPTEN)
-struct __clang_Interpreter_NewTag {
-} __ci_newtag;
-#if CLANG_VERSION_MAJOR >= 22
-extern "C" void* __clang_Interpreter_SetValueWithAlloc(void* This, void* OutVal,
-                                                       void* OpaqueType)
-#else
-void* __clang_Interpreter_SetValueWithAlloc(void* This, void* OutVal,
-                                            void* OpaqueType);
-#endif
-
-#if CLANG_VERSION_MAJOR >= 19
-    extern "C" void __clang_Interpreter_SetValueNoAlloc(void* This,
-                                                        void* OutVal,
-                                                        void* OpaqueType, ...);
-#elif CLANG_VERSION_MAJOR == 18
-void __clang_Interpreter_SetValueNoAlloc(void*, void*, void*);
-void __clang_Interpreter_SetValueNoAlloc(void*, void*, void*, void*);
-void __clang_Interpreter_SetValueNoAlloc(void*, void*, void*, float);
-void __clang_Interpreter_SetValueNoAlloc(void*, void*, void*, double);
-void __clang_Interpreter_SetValueNoAlloc(void*, void*, void*, long double);
-void __clang_Interpreter_SetValueNoAlloc(void*, void*, void*,
-                                         unsigned long long);
-#endif
-#endif // CPPINTEROP_USE_CLING
-
 namespace Cpp {
 
 using namespace clang;