review comments

Author: aaronj0

lib/CppInterOp/CppInterOp.cpp

@@ -95,19 +95,19 @@
 #if !defined(CPPINTEROP_USE_CLING) && !defined(EMSCRIPTEN)
 struct __clang_Interpreter_NewTag {
 } __ci_newtag;
-#if CLANG_VERSION_MAJOR >= 22
+#if CLANG_VERSION_MAJOR > 21
 extern "C" void* __clang_Interpreter_SetValueWithAlloc(void* This, void* OutVal,
                                                        void* OpaqueType)
 #else
 void* __clang_Interpreter_SetValueWithAlloc(void* This, void* OutVal,
                                             void* OpaqueType);
 #endif
 
-#if CLANG_VERSION_MAJOR >= 19
+#if CLANG_VERSION_MAJOR > 18
     extern "C" void __clang_Interpreter_SetValueNoAlloc(void* This,
                                                         void* OutVal,
                                                         void* OpaqueType, ...);
-#elif CLANG_VERSION_MAJOR == 18
+#else
 void __clang_Interpreter_SetValueNoAlloc(void*, void*, void*);
 void __clang_Interpreter_SetValueNoAlloc(void*, void*, void*, void*);
 void __clang_Interpreter_SetValueNoAlloc(void*, void*, void*, float);
@@ -3359,9 +3359,8 @@ CPPINTEROP_API JitCall MakeFunctionCallable(TCppConstFunction_t func) {
 
 namespace {
 #if !defined(CPPINTEROP_USE_CLING) && !defined(EMSCRIPTEN)
-static bool DefineAbsoluteSymbol(compat::Interpreter& I,
-                                 const char* linker_mangled_name,
-                                 uint64_t address) {
+bool DefineAbsoluteSymbol(compat::Interpreter& I,
+                          const char* linker_mangled_name, uint64_t address) {
   using namespace llvm;
   using namespace llvm::orc;