This issue is stale because it has been open for 90 days with no activity.

This issue was closed because it has been inactive for 14 days since being marked as stale.

@vgvassilev hi, i have come up with a solution for this.
The approach is:

• Change the function parameters to std::vectorstd::string in CppInterOp.h and CppInterOp.cpp.
• Inside CreateInterpreter defination, build the argument list as std::string, then convert it to const char* right befor interpreter construction, as it expects const char*.

Few Questions:

• Are there any hidden dependencies or callers that might be impacted by this change?
• I took a look at test.cpp at conda-forge/cppinterop-feedstock, should i update the test.cpp to pass std::string arguments directly?(https://github.com/conda-forge/cppinterop-feedstock/blob/3c03c943fe27b242a9f18dd1762d479a1040ac7e/recipe/test.cpp#L56C3-L61C54)

@vgvassilev hi, i have come up with a solution for this. The approach is:

• Change the function parameters to std::vectorstd::string in CppInterOp.h and CppInterOp.cpp.
• Inside CreateInterpreter defination, build the argument list as std::string, then convert it to const char* right befor interpreter construction, as it expects const char*.

Few Questions:

• Are there any hidden dependencies or callers that might be impacted by this change?
• I took a look at test.cpp at conda-forge/cppinterop-feedstock, should i update the test.cpp to pass std::string arguments directly?(https://github.com/conda-forge/cppinterop-feedstock/blob/3c03c943fe27b242a9f18dd1762d479a1040ac7e/recipe/test.cpp#L56C3-L61C54)

We should probably create an overload for this and deprecate the other interface.

Ok, i will do that. Should i also forward the control from the older function to overloaded function

@vgvassilev I have created the overloaded, but i am facing an issue.
//New Overload for CreateInterpreter, takes std::vector<std::string>
CPPINTEROP_API TInterp_t CreateInterpreter( const std::vector<std::string>& Args = {}, const std::vector<std::string>& GpuArgs = {});

[[deprecated("Use the overload that takes std::vector<std::string> instead.")]]
CPPINTEROP_API TInterp_t CreateInterpreter(const std::vector<const char*>& Args, const std::vector<const char*>& GpuArgs);

• First error while running the unittests was that "error: call of overloaded ‘CreateInterpreter()’ is ambiguous". I was able to fix it by removing the default arguments from deprecated declaration.
• Second error while running the unittests is "error: call of overloaded ‘CreateInterpreter(, )’ is ambiguous" for call like this "Cpp::CreateInterpreter({}, {"--cuda"});".

I am not sure how to resolve this, i am searching for a solution for this.

@vgvassilev i have opened a PR for this, you can take a look at the changes.