Skip to content

Conversation

@memsharded
Copy link
Member

Changelog: BugFix: Fix logic in EnvVars generation of .sh and .ps1 scripts for "unset" vs "empty" definition
Docs: https://github.com/conan-io/docs/pull/XXXX

For #19285 (comment)

@memsharded memsharded marked this pull request as ready for review November 29, 2025 10:47
@memsharded memsharded added this to the 2.24.0 milestone Nov 29, 2025
@memsharded memsharded requested a review from AbrilRBS November 29, 2025 10:47
@memsharded
Copy link
Member Author

Note @czoido that this can be "breaking" for some users that were relying on VAR= to "unset" the variable, while the documentation clearly states that the correct way to unset variables is VAR=!, so I think this is a valid bugfix

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is worth pursuing as a bugfix, this behaviour should be more consistent with user expectations

@czoido czoido merged commit dc8fdb5 into conan-io:develop2 Dec 1, 2025
16 checks passed
@memsharded memsharded deleted the fix/envars_unset branch December 1, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants