Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jupyter console broken on latest conda-forge. Regression from jupyter_client-7.0.2 #1511

Open
slonik-az opened this issue Sep 14, 2021 · 11 comments · Fixed by conda-forge/jupyter_console-feedstock#18

Comments

@slonik-az
Copy link

Regression against jupyter_console-6.4.0 and jupyter_client-7.0.2 first reported in jupyter/jupyter_console#251

@ocefpaf
Copy link
Member

ocefpaf commented Sep 14, 2021

Pinging @conda-forge/jupyter_console and @conda-forge/jupyter_client teams.

@davidbrochart
Copy link
Member

@slonik-az but it has nothing to do with conda-forge, does it?

@ocefpaf
Copy link
Member

ocefpaf commented Sep 14, 2021

@slonik-az but it has nothing to do with conda-forge, does it?

Even it it doesn't we need to know if we should move the packages to broken or not.

@davidbrochart
Copy link
Member

I don't think so, I even opened a PR in Jupyter Console ahead of jupyter_client's 7.0 release, but it was not merged.

@slonik-az
Copy link
Author

slonik-az commented Sep 14, 2021

@slonik-az but it has nothing to do with conda-forge, does it?

The reason I cross-posted it here is that downgrading to jupyter_client 6.1.12 seems to resolve the issue with jupyter console. It is up to conda-forge to decide whether to roll back broken version or to label the package broken. In any case conda-forge needs to be aware of what is going on.

@davidbrochart
Copy link
Member

But which package/version do you consider broken?

@slonik-az
Copy link
Author

slonik-az commented Sep 14, 2021

But which package/version do you consider broken?

IMHO, jupyter console is broken. Your patch has been available for review and merging since early July. But who knows how long it will take to fix the jupyter console. In meanwhile, to preserve my workflow I downgraded jupyter_client to 6.1.12. Hope it won't break anything else. :-)

@davidbrochart
Copy link
Member

Maybe Jupyter Console is just unmaintained, but I don't think we can mark it as broken. It's probably just a matter of pinning jupyter_client <7.0 in its feedstock, until jupyter/jupyter_console#244 is merged and released.

@slonik-az
Copy link
Author

Maybe Jupyter Console is just unmaintained,

I doubt that. jupyter_console is a dependency ofjupyter. Also it is a very convenient way to connect a terminal to a running kernel for debugging and what not.

@bollwyvl
Copy link
Contributor

jupyter_console is a dependency of jupyter

As a bit of history: the jupyter package is a historical artifact which preserves everything that was IPython prior to The Big Split, and as such brings in a lot of stuff (e.g. qt), and without pins for much of anything, nor does it include a number of new, first-party jupyter components (e.g. jupyterlab).

@slonik-az
Copy link
Author

Without jupyter console how else could I connect a terminal to a running kernel? IPython does not except --existing option any longer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

4 participants