Fix CI failures resulting from missing simulators #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Rebello <[email protected]>
Signed-off-by: Michael Rebello <[email protected]>
Contributor
|
It looks like the issue is that we still need to pin the OS version, but the device pinning should be fine to remove. The OS version is somewhat tied to the Xcode version we're targeting too, so keeping those updated and in sync may just have to be something we deal with. |
Signed-off-by: Michael Rebello <[email protected]>
Collaborator
Author
|
Hmm maybe I'm missing something but that doesn't seem to be working here @eseay: https://github.com/connectrpc/connect-swift/actions/runs/19685231856/job/56389006053?pr=374 |
Collaborator
Author
|
Going with #375 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Actions keeps changing supported simulators on our CI machines from underneath us, breaking CI checks (example here: https://github.com/connectrpc/connect-swift/actions/runs/19645507500/job/56271087929?pr=373).
This PR removes the simulator/OS pinning - I think this will result in fewer net CI failures since we can generally continue using the defaults on the machines (note that we are still pinning macOS versions on the machines, as well as Xcode versions).