Merge pull request #4166 from apostasie/fix-2025-04-loguri-debug

AkihiroSuda · web-flow · commit a75f8a976215 · 2025-04-26T10:42:19.000+09:00
[QOL]: enhance error information for failing logURI
diff --git a/pkg/cioutil/container_io.go b/pkg/cioutil/container_io.go
@@ -176,7 +176,7 @@ func NewContainerIO(namespace string, logURI string, tty bool, stdin io.Reader,
 			cmd.ExtraFiles = append(cmd.ExtraFiles, stdoutr, stderrr, w)
 
 			if err := cmd.Start(); err != nil {
-				return nil, fmt.Errorf("failed to start binary process with cmdArgs %v: %w", cmd.Args, err)
+				return nil, fmt.Errorf("failed to start binary process with cmdArgs %v (logURI: %s): %w", cmd.Args, logURI, err)
 			}
 
 			closers = append(closers, func() error { return cmd.Process.Kill() })

Original file line number	Diff line number	Diff line change
`@@ -176,7 +176,7 @@ func NewContainerIO(namespace string, logURI string, tty bool, stdin io.Reader,`
`176`	`176`	`cmd.ExtraFiles = append(cmd.ExtraFiles, stdoutr, stderrr, w)`
`177`	`177`
`178`	`178`	`if err := cmd.Start(); err != nil {`
`179`		`- return nil, fmt.Errorf("failed to start binary process with cmdArgs %v: %w", cmd.Args, err)`
	`179`	`+ return nil, fmt.Errorf("failed to start binary process with cmdArgs %v (logURI: %s): %w", cmd.Args, logURI, err)`
`180`	`180`	`}`
`181`	`181`
`182`	`182`	`closers = append(closers, func() error { return cmd.Process.Kill() })`