Merge pull request #4121 from apostasie/fix-convert

AkihiroSuda · web-flow · commit d2b39639b06a · 2025-04-19T03:49:48.000+09:00
[Fix]: image delete in convert (#3510)
diff --git a/pkg/cmd/image/convert.go b/pkg/cmd/image/convert.go
@@ -208,8 +208,7 @@ func Convert(ctx context.Context, client *containerd.Client, srcRawRef, targetRa
 			return err
 		}
 		is := client.ImageService()
-		_ = is.Delete(ctx, newI.Name, images.SynchronousDelete())
-		finimg, err := is.Create(ctx, *newI)
+		finimg, err := is.Update(ctx, *newI)
 		if err != nil {
 			return err
 		}

Original file line number	Diff line number	Diff line change
`@@ -208,8 +208,7 @@ func Convert(ctx context.Context, client *containerd.Client, srcRawRef, targetRa`
`208`	`208`	`return err`
`209`	`209`	`}`
`210`	`210`	`is := client.ImageService()`
`211`		`- _ = is.Delete(ctx, newI.Name, images.SynchronousDelete())`
`212`		`- finimg, err := is.Create(ctx, *newI)`
	`211`	`+ finimg, err := is.Update(ctx, *newI)`
`213`	`212`	`if err != nil {`
`214`	`213`	`return err`
`215`	`214`	`}`