Remove Create method from controllerHandler

Signed-off-by: Lokesh Mandvekar <[email protected]>

Author: lsm5

common/pkg/cgroups/blkio_linux.go

@@ -29,11 +29,6 @@ func (c *linuxBlkioHandler) Apply(ctr *CgroupControl, res *cgroups.Resources) er
 	return man.Set(res)
 }
 
-// Create the cgroup.
-func (c *linuxBlkioHandler) Create(ctr *CgroupControl) (bool, error) {
-	return false, nil
-}
-
 // Destroy the cgroup.
 func (c *linuxBlkioHandler) Destroy(ctr *CgroupControl) error {
 	return rmDirRecursively(ctr.getCgroupv1Path(Blkio))

common/pkg/cgroups/cgroups_linux.go

@@ -51,7 +51,6 @@ type controller struct {
 }
 
 type controllerHandler interface {
-	Create(*CgroupControl) (bool, error)
 	Apply(*CgroupControl, *cgroups.Resources) error
 	Destroy(*CgroupControl) error
 	Stat(*CgroupControl, *cgroups.Stats) error
@@ -171,15 +170,6 @@ func (c *CgroupControl) initialize() (err error) {
 	if err := createCgroupv2Path(filepath.Join(cgroupRoot, c.config.Path)); err != nil {
 		return fmt.Errorf("creating cgroup path %s: %w", c.config.Path, err)
 	}
-	for name, handler := range handlers {
-		created, err := handler.Create(c)
-		if err != nil {
-			return err
-		}
-		if created {
-			createdSoFar[name] = handler
-		}
-	}
 	return nil
 }
 

common/pkg/cgroups/cpu_linux.go

@@ -28,11 +28,6 @@ func (c *linuxCPUHandler) Apply(ctr *CgroupControl, res *cgroups.Resources) erro
 	return man.Set(res)
 }
 
-// Create the cgroup.
-func (c *linuxCPUHandler) Create(ctr *CgroupControl) (bool, error) {
-	return false, nil
-}
-
 // Destroy the cgroup.
 func (c *linuxCPUHandler) Destroy(ctr *CgroupControl) error {
 	return rmDirRecursively(ctr.getCgroupv1Path(CPU))

common/pkg/cgroups/memory_linux.go

@@ -27,11 +27,6 @@ func (c *linuxMemHandler) Apply(ctr *CgroupControl, res *cgroups.Resources) erro
 	return man.Set(res)
 }
 
-// Create the cgroup.
-func (c *linuxMemHandler) Create(ctr *CgroupControl) (bool, error) {
-	return false, nil
-}
-
 // Destroy the cgroup.
 func (c *linuxMemHandler) Destroy(ctr *CgroupControl) error {
 	return rmDirRecursively(ctr.getCgroupv1Path(Memory))

common/pkg/cgroups/pids_linux.go

@@ -27,11 +27,6 @@ func (c *linuxPidHandler) Apply(ctr *CgroupControl, res *cgroups.Resources) erro
 	return man.Set(res)
 }
 
-// Create the cgroup.
-func (c *linuxPidHandler) Create(ctr *CgroupControl) (bool, error) {
-	return false, nil
-}
-
 // Destroy the cgroup.
 func (c *linuxPidHandler) Destroy(ctr *CgroupControl) error {
 	return rmDirRecursively(ctr.getCgroupv1Path(Pids))