fix: handle ESLint rule @typescript-eslint/explicit-function-return-type (#1705)

* fix: handle ESLint rule @typescript-eslint/explicit-function-return-type

Fixes #1699

Signed-off-by: Jeff MAURY <[email protected]>

Author: jeffmaury

eslint.config.mjs

@@ -204,7 +204,6 @@ export default [
       ],
 
       // disabled as code in this project is not yet compliant:
-      '@typescript-eslint/explicit-function-return-type': 'off',
       '@typescript-eslint/no-explicit-any': 'off',
       '@typescript-eslint/prefer-nullish-coalescing': 'off',
       '@typescript-eslint/no-empty-object-type': 'off',

packages/backend/src/managers/SnippetManager.ts

@@ -77,7 +77,7 @@ export class SnippetManager extends Publisher<Language[]> implements Disposable
     });
   }
 
-  init() {
+  init(): void {
     this.#languages = getLanguageList();
     this.addVariant('java', 'Quarkus Langchain4J', quarkusLangchain4Jgenerator);
     this.addVariant('java', 'OkHttp', javaOkHttpGenerator);

packages/backend/src/managers/apiServer.ts

@@ -189,7 +189,7 @@ export class ApiServer implements Disposable {
     this.#listener?.close();
   }
 
-  private doErr(res: Response, message: string, err: unknown) {
+  private doErr(res: Response, message: string, err: unknown): void {
     res.status(500).json({
       message,
       errors: [err instanceof Error ? err.message : err],
@@ -235,13 +235,13 @@ export class ApiServer implements Disposable {
     }
   }
 
-  private streamLine(res: Response, obj: unknown, stream: boolean) {
+  private streamLine(res: Response, obj: unknown, stream: boolean): void {
     if (stream) {
       res.write(JSON.stringify(obj) + '\n');
     }
   }
 
-  private sendResult(res: Response, obj: unknown, code: number, stream: boolean) {
+  private sendResult(res: Response, obj: unknown, code: number, stream: boolean): void {
     if (stream) {
       this.streamLine(res, obj, stream);
     } else {

packages/backend/src/managers/application/applicationManager.ts

@@ -487,7 +487,7 @@ export class ApplicationManager extends Publisher<ApplicationState[]> implements
     this.notify();
   }
 
-  init() {
+  init(): void {
     this.podmanConnection.onPodmanConnectionEvent(() => {
       this.refresh();
     });
@@ -499,7 +499,7 @@ export class ApplicationManager extends Publisher<ApplicationState[]> implements
       this.forgetPodById(podId);
     });
 
-    const ticker = () => {
+    const ticker = (): void => {
       this.checkPodsHealth()
         .catch((err: unknown) => {
           console.error('error getting pods statuses', err);
@@ -520,7 +520,7 @@ export class ApplicationManager extends Publisher<ApplicationState[]> implements
     this.refresh();
   }
 
-  protected adoptPod(pod: PodInfo) {
+  protected adoptPod(pod: PodInfo): void {
     if (!pod.Labels) {
       return;
     }
@@ -545,7 +545,7 @@ export class ApplicationManager extends Publisher<ApplicationState[]> implements
     this.updateApplicationState(recipeId, modelId, state);
   }
 
-  protected forgetPodById(podId: string) {
+  protected forgetPodById(podId: string): void {
     const app = Array.from(this.#applications.values()).find(p => p.pod.Id === podId);
     if (!app) {
       return;

packages/backend/src/managers/catalogManager.spec.ts

@@ -68,7 +68,7 @@ vi.mock('@podman-desktop/api', async () => {
       TASK_WIDGET: 'TASK_WIDGET',
     },
     fs: {
-      createFileSystemWatcher: () => ({
+      createFileSystemWatcher: (): unknown => ({
         onDidCreate: vi.fn(),
         onDidDelete: vi.fn(),
         onDidChange: vi.fn(),

packages/backend/src/managers/catalogManager.ts

@@ -140,7 +140,7 @@ export class CatalogManager extends Publisher<ApplicationCatalog> implements Dis
     this.notify();
   }
 
-  override notify() {
+  override notify(): void {
     super.notify();
     this._onUpdate.fire(this.getCatalog());
   }

packages/backend/src/managers/gitManager.ts

@@ -28,7 +28,7 @@ export interface GitCloneInfo {
 }
 
 export class GitManager {
-  async cloneRepository(gitCloneInfo: GitCloneInfo) {
+  async cloneRepository(gitCloneInfo: GitCloneInfo): Promise<void> {
     // clone repo
     await git.clone({
       fs,

packages/backend/src/managers/modelsManager.spec.ts

@@ -76,7 +76,7 @@ vi.mock('@podman-desktop/api', () => {
       exec: vi.fn(),
     },
     fs: {
-      createFileSystemWatcher: () => ({
+      createFileSystemWatcher: (): unknown => ({
         onDidCreate: vi.fn(),
         onDidDelete: vi.fn(),
         onDidChange: vi.fn(),
@@ -91,7 +91,7 @@ vi.mock('@podman-desktop/api', () => {
 vi.mock('../utils/downloader', () => ({
   isCompletionEvent: mocks.isCompletionEventMock,
   Downloader: class {
-    get completed() {
+    get completed(): boolean {
       return mocks.getDownloaderCompleter();
     }
     onEvent = mocks.onEventDownloadMock;
@@ -136,23 +136,23 @@ beforeEach(() => {
 
 const dirent = [
   {
-    isDirectory: () => true,
+    isDirectory: (): boolean => true,
     path: '/home/user/appstudio-dir',
     name: 'model-id-1',
   },
   {
-    isDirectory: () => true,
+    isDirectory: (): boolean => true,
     path: '/home/user/appstudio-dir',
     name: 'model-id-2',
   },
   {
-    isDirectory: () => false,
+    isDirectory: (): boolean => false,
     path: '/home/user/appstudio-dir',
     name: 'other-file-should-be-ignored.txt',
   },
 ] as fs.Dirent[];
 
-function mockFiles(now: Date) {
+function mockFiles(now: Date): void {
   vi.spyOn(os, 'homedir').mockReturnValue('/home/user');
   const existsSyncSpy = vi.spyOn(fs, 'existsSync');
   existsSyncSpy.mockImplementation((path: PathLike) => {

packages/backend/src/managers/modelsManager.ts

@@ -61,7 +61,7 @@ export class ModelsManager implements Disposable {
     this.#disposables = [];
   }
 
-  init() {
+  init(): void {
     const disposable = this.catalogManager.onUpdate(() => {
       this.loadLocalModels().catch((err: unknown) => {
         console.error(`Something went wrong when loading local models`, err);
@@ -80,10 +80,10 @@ export class ModelsManager implements Disposable {
     this.#disposables.forEach(d => d.dispose());
   }
 
-  async loadLocalModels() {
+  async loadLocalModels(): Promise<void> {
     this.#models.clear();
     this.catalogManager.getModels().forEach(m => this.#models.set(m.id, m));
-    const reloadLocalModels = async () => {
+    const reloadLocalModels = async (): Promise<void> => {
       this.getLocalModelsFromDisk();
       await this.sendModelsInfo();
     };
@@ -98,11 +98,11 @@ export class ModelsManager implements Disposable {
     await reloadLocalModels();
   }
 
-  getModelsInfo() {
+  getModelsInfo(): ModelInfo[] {
     return [...this.#models.values()];
   }
 
-  async sendModelsInfo() {
+  async sendModelsInfo(): Promise<void> {
     const models = this.getModelsInfo();
     await this.webview.postMessage({
       id: Messages.MSG_NEW_MODELS_STATE,

packages/backend/src/managers/monitoringManager.spec.ts

@@ -98,7 +98,7 @@ test('expect webview to be notified when statsContainer call back', async () =>
   let mCallback: ((stats: ContainerStatsInfo) => void) | undefined;
   vi.mocked(containerEngine.statsContainer).mockImplementation(async (_engineId, _id, callback) => {
     mCallback = callback;
-    return { dispose: () => {} };
+    return { dispose: (): void => {} };
   });
 
   await manager.monitor('randomContainerId', 'dummyEngineId');
@@ -135,7 +135,7 @@ test('expect stats to cumulate', async () => {
   let mCallback: ((stats: ContainerStatsInfo) => void) | undefined;
   vi.mocked(containerEngine.statsContainer).mockImplementation(async (_engineId, _id, callback) => {
     mCallback = callback;
-    return { dispose: () => {} };
+    return { dispose: (): void => {} };
   });
 
   await manager.monitor('randomContainerId', 'dummyEngineId');
@@ -160,7 +160,7 @@ test('expect old stats to be removed', async () => {
   let mCallback: ((stats: ContainerStatsInfo) => void) | undefined;
   vi.mocked(containerEngine.statsContainer).mockImplementation(async (_engineId, _id, callback) => {
     mCallback = callback;
-    return { dispose: () => {} };
+    return { dispose: (): void => {} };
   });
 
   await manager.monitor('randomContainerId', 'dummyEngineId');