Skip to content

new image sfx from automation_images#417 #27222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

new image sfx from automation_images#417 #27222

wants to merge 1 commit into from
+1 −1

Conversation

@timcoding1988
Copy link
Collaborator

@timcoding1988 timcoding1988 commented Oct 2, 2025 •
edited
Loading

new vm image

Does this PR introduce a user-facing change?

None

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 2, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: timcoding1988
Once this PR has been reviewed and has the lgtm label, please assign baude for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Honny1
Honny1 reviewed Oct 3, 2025
View reviewed changes
Copy link
Member

@Honny1 Honny1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@timcoding1988 Can you rerun CI? This looks like flakiness.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2025
@baude
Copy link
Member

baude commented Oct 3, 2025

lets not accidently let this get merged until it has been shopped around. also, id feel better if @Luap99 gave a thumbs up
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 3, 2025
@baude baude removed the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2025
@Luap99
Copy link
Member

Luap99 commented Oct 6, 2025

Yeah debian is still broken so we still need the old kernel work around so you have to drop the from the image build

@Luap99
Copy link
Member

Luap99 commented Oct 6, 2025

Also in future it please include a click-able link to the build PR containers/automation_images#417

@Honny1 Honny1 removed their assignment Oct 9, 2025
@timcoding1988 timcoding1988 force-pushed the new_automation_image_sfx branch from e037e53 to ed07537 Compare October 29, 2025 19:32
@timcoding1988 timcoding1988 force-pushed the new_automation_image_sfx branch from ed07537 to 524a3cc Compare October 30, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Honny1 Honny1 Honny1 left review comments

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@timcoding1988 @baude @Luap99 @Honny1