fix(personalize): filter lytics audiences in experience variants during import

Author: cs-raj

.talismanrc

@@ -1,8 +1,8 @@
 fileignoreconfig:
 - filename: package-lock.json
-  checksum: 1b011574c5a640f7132f2dcabfced269cb497ddd3270524ec32abe3cb4a95cb5
+  checksum: c91b9e5fba1c84c0b6de15ad2f8cce698a5c781c9db31bebb7a3ad63ee88d9e1
 - filename: pnpm-lock.yaml
-  checksum: 91ffcd3364bcbef7dad0d25547849a572dc9ebd004999c3ede85c7730959a2e5
+  checksum: 8405d813bbcc584a7540542acfdbc27f5b8768da60354b7eff9f6cd93c3d832d
 - filename: packages/contentstack-bootstrap/src/bootstrap/utils.ts
   checksum: 6e6fb00bb11b03141e5ad27eeaa4af9718dc30520c3e73970bc208cc0ba2a7d2
 version: '1.0'

package-lock.json

@@ -7,7 +7,7 @@
   "dependencies": {
     "@contentstack/cli-command": "~1.7.2",
     "@oclif/core": "^4.3.3",
-    "@contentstack/cli-variants": "~1.3.7",
+    "@contentstack/cli-variants": "~1.3.8",
     "@contentstack/cli-utilities": "~1.17.4",
     "async": "^3.2.6",
     "big-json": "^3.2.0",

packages/contentstack-export/package.json

@@ -8,7 +8,7 @@
     "@contentstack/cli-audit": "~1.18.0",
     "@contentstack/cli-command": "~1.7.2",
     "@contentstack/cli-utilities": "~1.17.4",
-    "@contentstack/cli-variants": "~1.3.7",
+    "@contentstack/cli-variants": "~1.3.8",
     "@oclif/core": "^4.3.0",
     "big-json": "^3.2.0",
     "bluebird": "^3.7.2",

packages/contentstack-import/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@contentstack/cli-variants",
-  "version": "1.3.7",
+  "version": "1.3.8",
   "description": "Variants plugin",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",

packages/contentstack-variants/package.json

@@ -203,9 +203,11 @@ export default class Experiences extends PersonalizationAdapter<ImportConfig> {
       let versionReqObj = lookUpAudiences(version, this.audiencesUid) as CreateExperienceVersionInput;
       versionReqObj = lookUpEvents(version, this.eventsUid) as CreateExperienceVersionInput;
 
-      if (versionReqObj && versionReqObj.status) {
+      if (versionReqObj && versionReqObj.status && (versionReqObj.variants?.length ?? 0) > 0) {
         versionMap[versionReqObj.status] = versionReqObj;
         log.debug(`Mapped version with status: ${versionReqObj.status}`, this.config.context);
+      } else if (versionReqObj?.status && !(versionReqObj.variants?.length ?? 0)) {
+        log.warn(`Skipping version ${versionReqObj.status}: no valid variants (all had unmapped Lytics audiences)`, this.config.context);
       }
     });
 

packages/contentstack-variants/src/import/experiences.ts

@@ -65,11 +65,11 @@ export const lookUpAudiences = (
       const expVariations = experience.variants[index];
       log.debug(`Processing variant ${index + 1}/${experience.variants.length} of type: ${expVariations['__type']}`);
 
-      if (expVariations['__type'] === 'SegmentedVariant' && expVariations?.audiences?.length) {
-        log.debug(`Found ${expVariations.audiences.length} audiences in SegmentedVariant`);
-        updateAudiences(expVariations.audiences, audiencesUid);
-        
-        if (!expVariations.audiences.length) {
+      if (expVariations['__type'] === 'SegmentedVariant' && (expVariations?.audiences?.length || expVariations?.lyticsAudiences?.length)) {
+        log.debug(`Found ${expVariations.audiences?.length ?? 0} audiences in SegmentedVariant`);
+        if (expVariations?.audiences?.length) updateAudiences(expVariations.audiences, audiencesUid);
+        if (expVariations?.lyticsAudiences?.length) updateAudiences(expVariations.lyticsAudiences, audiencesUid);
+        if (!(expVariations.audiences?.length || expVariations?.lyticsAudiences?.length)) {
           log.warn('No audiences remaining after mapping. Removing variant.');
           experience.variants.splice(index, 1);
         }

packages/contentstack-variants/src/utils/audiences-helper.ts

@@ -0,0 +1 @@
+{}

packages/contentstack-variants/test/unit/mock/contents/mapper/personalize/attributes/uid-mapping.json

@@ -0,0 +1 @@
+{"contentstack-audience-001":"new-contentstack-uid","no-source-audience-001":"new-contentstack-uid"}

packages/contentstack-variants/test/unit/mock/contents/mapper/personalize/audiences/uid-mapping.json

@@ -0,0 +1,44 @@
+[
+  {
+    "uid": "contentstack-audience-001",
+    "name": "Contentstack Test Audience",
+    "description": "Audience with rules",
+    "definition": {
+      "__type": "RuleCombination",
+      "combinationType": "AND",
+      "rules": [
+        {
+          "__type": "Rule",
+          "attribute": { "__type": "PresetAttributeReference", "ref": "DEVICE_TYPE" },
+          "attributeMatchOptions": { "__type": "StringMatchOptions", "value": "MOBILE" },
+          "attributeMatchCondition": "STRING_EQUALS",
+          "invertCondition": false
+        }
+      ]
+    }
+  },
+  {
+    "uid": "lytics-audience-001",
+    "name": "Lytics Audience",
+    "description": "From Lytics",
+    "slug": "lytics_audience",
+    "source": "LYTICS"
+  },
+  {
+    "uid": "lytics-lowercase-001",
+    "name": "Lytics Lowercase",
+    "description": "source is lowercase",
+    "slug": "lytics_lowercase",
+    "source": "lytics"
+  },
+  {
+    "uid": "no-source-audience-001",
+    "name": "No Source Audience",
+    "description": "Audience without source field",
+    "definition": {
+      "__type": "RuleCombination",
+      "combinationType": "AND",
+      "rules": []
+    }
+  }
+]