Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiselection hints are too obscure #2033

Open
InAnYan opened this issue Mar 13, 2025 · 3 comments · May be fixed by #2034
Open

Multiselection hints are too obscure #2033

InAnYan opened this issue Mar 13, 2025 · 3 comments · May be fixed by #2034

Comments

@InAnYan
Copy link
Contributor

InAnYan commented Mar 13, 2025

Actual Situation

Image

  • <space> to select - select what?
  • <a> to toggle - toggle what?
  • <i> to invert - invert what?

Initially, I thought that all these actions refer to a (one) selection. But in this case, all these actions would do the same thing.

Only after trying and experimenting with a toy template I understood everything.

Desired Situation

Let's address this bit by bit.

What actions do:

  • <space> to select - toggles a single option under the arrow.
  • <a> to toggle - either:
    • Selects every option.
    • Deselects every option.
  • <i> to invert - inverts current assignments. What was selected become deselected, what was deselected became selected.

Scopes:

  • <space> to select - single choice.
  • <a> to toggle - all choices.
  • <i> to invert - all choices.

Proposed solution

Maybe rewrite it like this:

  • <space> to select - <space> toggle
  • <a> to toggle - <a> select all
  • <i> to invert - <i> invert selection

If we came to consensus, I can make a PR

@InAnYan
Copy link
Contributor Author

InAnYan commented Mar 13, 2025

Maybe also <enter> confirm

@pawamoy
Copy link
Contributor

pawamoy commented Mar 13, 2025

Nice suggestion, thanks!

I would slightly change it to:

  • <space> (un)select
  • <a> (un)select all
  • <i> invert selection

Also yes to <enter> confirm.

@InAnYan
Copy link
Contributor Author

InAnYan commented Mar 13, 2025

Not so fast. This is a problem in underlying library questionary.

Aha! It actually has instruction parameter which we can use: https://questionary.readthedocs.io/en/stable/pages/types.html#questionary.checkbox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants