Skip to content

Commit 2a8d1e6

Browse files
committed
osbuild: don't compress in the qemu stage for now
We'll open a PR upstream to make compression an option for this stage, but for now we'll just disable it in the code because we know we don't want it: coreos/fedora-coreos-tracker#1653 (comment)
1 parent ade15b9 commit 2a8d1e6

File tree

2 files changed

+31
-0
lines changed

2 files changed

+31
-0
lines changed

build.sh

+1
Original file line numberDiff line numberDiff line change
@@ -190,6 +190,7 @@ patch_osbuild() {
190190
/usr/lib/coreos-assembler/0001-stages-zipl.inst-improve-kernel-initrd-path-resoluti.patch \
191191
/usr/lib/coreos-assembler/0002-stages-zipl.inst-support-appending-kernel-options.patch \
192192
/usr/lib/coreos-assembler/0001-stages-copy-allow-copying-from-the-tree.patch \
193+
/usr/lib/coreos-assembler/0001-stages-qemu-don-t-use-internal-compression-for-now.patch \
193194
| patch -d /usr/lib/osbuild -p1
194195

195196
# And then move the files back; supermin appliance creation will need it back
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
From 372df8e1adb3c76f092ed47a45ee8637a247c786 Mon Sep 17 00:00:00 2001
2+
From: Dusty Mabe <[email protected]>
3+
Date: Mon, 5 Feb 2024 17:38:41 -0500
4+
Subject: [PATCH] stages(qemu): don't use internal compression for now
5+
6+
Until this is an option in the stage let's disable it for now
7+
https://github.com/coreos/fedora-coreos-tracker/issues/1653#issuecomment-1928342241
8+
---
9+
stages/org.osbuild.qemu | 5 ++++-
10+
1 file changed, 4 insertions(+), 1 deletion(-)
11+
12+
diff --git a/stages/org.osbuild.qemu b/stages/org.osbuild.qemu
13+
index 98a04f00..07172b3d 100755
14+
--- a/stages/org.osbuild.qemu
15+
+++ b/stages/org.osbuild.qemu
16+
@@ -140,7 +140,10 @@ SCHEMA_2 = r"""
17+
18+
19+
def qcow2_arguments(options):
20+
- argv = ["-c"]
21+
+ # No internal compression in CoreOS for now.
22+
+ # https://github.com/coreos/fedora-coreos-tracker/issues/1653#issuecomment-1928342241
23+
+ # argv = ["-c"]
24+
+ argv = []
25+
compat = options.get("compat")
26+
27+
if compat:
28+
--
29+
2.43.0
30+

0 commit comments

Comments
 (0)