Skip to content

Accordion dark theme CSS variable name for button mismatched #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hadifikri opened this issue Oct 11, 2023 · 0 comments
Closed

Accordion dark theme CSS variable name for button mismatched #457

hadifikri opened this issue Oct 11, 2023 · 0 comments

Comments

@hadifikri
Copy link

hadifikri commented Oct 11, 2023

In .accordion.scss

.accordion {
  // scss-docs-start accordion-css-vars
 ...
  --#{$prefix}accordion-btn-padding-x: #{$accordion-button-padding-x};
  --#{$prefix}accordion-btn-padding-y: #{$accordion-button-padding-y};
  --#{$prefix}accordion-btn-color: #{$accordion-button-color};
  --#{$prefix}accordion-btn-bg: #{$accordion-button-bg};
  --#{$prefix}accordion-btn-icon: #{escape-svg($accordion-button-icon)};
  --#{$prefix}accordion-btn-icon-width: #{$accordion-icon-width};
  --#{$prefix}accordion-btn-icon-transform: #{$accordion-icon-transform};
  --#{$prefix}accordion-btn-icon-transition: #{$accordion-icon-transition};
  --#{$prefix}accordion-btn-active-icon: #{escape-svg($accordion-button-active-icon)};
  --#{$prefix}accordion-btn-focus-border-color: #{$accordion-button-focus-border-color};
  --#{$prefix}accordion-btn-focus-box-shadow: #{$accordion-button-focus-box-shadow};
  ...
  --#{$prefix}accordion-active-color: #{$accordion-button-active-color};
  --#{$prefix}accordion-active-bg: #{$accordion-button-active-bg};
...
  // scss-docs-end accordion-css-vars
}

In dark theme (themes/dark/_variables.scss), the $accordion-theme-map use

"accordion-button-color":               $accordion-button-color-dt,
"accordion-button-bg":                  $accordion-button-bg-dt,
"accordion-button-active-bg":           $accordion-button-active-bg-dt,
"accordion-button-active-color":        $accordion-button-active-color-dt,
"accordion-button-focus-border-color":  $accordion-button-focus-border-color-dt,
"accordion-button-icon":                $accordion-button-icon-dt,
"accordion-button-active-icon":         $accordion-button-active-icon-dt

Resulting in :

image

"accordion-button-active-bg":           $accordion-button-active-bg-dt,
"accordion-button-active-color":        $accordion-button-active-color-dt,

also should be

"accordion-active-bg":           $accordion-button-active-bg-dt,
"accordion-active-color":        $accordion-button-active-color-dt,
@mrholek mrholek closed this as completed Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants