I've added the ability to check your wallet balance easily, plus a few more features #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aly mine with the fake random address.
… there is now a message that tells the user to save their public key in the miner_config.py file.
… not another. Stopped the miner from running if the miner address was not set.
|
I'd like to run this code myself, can I share the entire code? |
Sure :) |
|
If the developer forgets to delete the wallet file, I wonder where the development would be safer if the newly created wallet was added as well. I'm sorry I'm a novice enlightener and I don't know much about this. |
|
Where does development become safer? |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, I've changed the way that blocks are saved. All elements of the block retain their original data type. This is especially beneficial for the block data. The block data can later be accessed by other files far easier than the previous method of saving the block data as a string.
A minor change, but the MINER_ADDRESS in the miner_config.py file now starts of blank. In the miner.py file, I've made it so that the miner won't start mining if the MINER_ADDRESS is left blank. This will stop new users from accidentally mining while not using their own wallet address. In the wallet.py file, when a user generates a new wallet, there is a message reminding them to save their wallet address in the miner_config.py file.
Also in the wallet.py file, the newly generated wallet also gets added to the .gitignore in case the the developer forgets to delete the wallet file. This makes development slightly more secure.
Users are now also able to check their wallet balance. My code loops through each block, and each transaction within that, then adds or subtracts, or does nothing to the wallet's balance accordingly. This is as per issue #82
This is my first pull request on this project. I'd really appreciate it if you could take a look through my code.