Skip to content

Conversation

@mmsqe
Copy link
Contributor

@mmsqe mmsqe commented Nov 27, 2025

Description

Problem:

  • when new fields (such as max_supply) are added to proto files, we need api replacement (cosmossdk.io/api => ../api) to use the latest generated API files.
  • modules like nft or crisis have been removed from api/cosmos, builds will fail due to missing packages.

Solution:

  • separate deprecated modules into the contrib, distinct from api, to enable and unblock new proto changes without affecting legacy code.

@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.68%. Comparing base (bd5f14e) to head (0e6d953).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #25613      +/-   ##
==========================================
+ Coverage   68.39%   70.68%   +2.28%     
==========================================
  Files         856      850       -6     
  Lines       55855    55893      +38     
==========================================
+ Hits        38201    39506    +1305     
+ Misses      17654    16387    -1267     
Files with missing lines Coverage Δ
contrib/x/group/module/autocli.go 100.00% <100.00%> (ø)
contrib/x/group/module/module.go 46.25% <ø> (ø)
testutil/configurator/configurator.go 80.42% <ø> (ø)

... and 67 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mmsqe mmsqe changed the title chore: x/group is not cleaned up chore: separate deprecated contrib with api module Nov 27, 2025
fix path
@github-actions github-actions bot removed the C:x/genutil genutil module issues label Nov 28, 2025
@mmsqe mmsqe changed the title chore: separate deprecated contrib with api module chore: separated deprecated modules into the contrib directory Nov 28, 2025
@mmsqe mmsqe marked this pull request as ready for review November 28, 2025 04:44
@github-actions github-actions bot removed the C:CLI label Nov 29, 2025
protoiface "google.golang.org/protobuf/runtime/protoiface"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
io "io"
reflect "reflect"

Check notice

Code scanning / CodeQL

Sensitive package import Note

Certain system packages contain functions which may be a possible source of non-determinism
protoiface "google.golang.org/protobuf/runtime/protoiface"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
io "io"
reflect "reflect"

Check notice

Code scanning / CodeQL

Sensitive package import Note

Certain system packages contain functions which may be a possible source of non-determinism
protoiface "google.golang.org/protobuf/runtime/protoiface"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
io "io"
reflect "reflect"

Check notice

Code scanning / CodeQL

Sensitive package import Note

Certain system packages contain functions which may be a possible source of non-determinism
@aljo242 aljo242 added this pull request to the merge queue Dec 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 1, 2025
@aljo242 aljo242 added this pull request to the merge queue Dec 1, 2025
Merged via the queue into cosmos:main with commit e857245 Dec 1, 2025
42 checks passed
warpbuild-benchmark-bot bot added a commit to WarpBuilds/cosmos-sdk that referenced this pull request Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants