Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unit validation to all the input objects #37

Open
etheban opened this issue May 25, 2020 · 4 comments
Open

Add Unit validation to all the input objects #37

etheban opened this issue May 25, 2020 · 4 comments
Labels
development Development version enhancement New feature or request

Comments

@etheban
Copy link
Contributor

etheban commented May 25, 2020

We should add the field 'unit' to all the input objects.
Then when can add a method in Model to validate the input.

We can use the DimVar class provided by the MatlabTool package.
Obviously the check should only be performed once and it should be optional (for compatibility reason)

https://www.mathworks.com/matlabcentral/mlc-downloads/downloads/submissions/38977/versions/26/previews/html/u.html

@etheban etheban added the enhancement New feature or request label May 25, 2020
@FriesischScott
Copy link
Member

Wow, looks very interesting.

@etheban
Copy link
Contributor Author

etheban commented May 25, 2020

Good we agree on something :D
It should also be simple to implement.

@FriesischScott
Copy link
Member

Is available on Github and can be included as a submodule: https://github.com/tgvoskuilen/MatlabTools

Not sure how simple it would be to implement though.

@FriesischScott FriesischScott added the development Development version label May 25, 2020
@etheban
Copy link
Contributor Author

etheban commented May 25, 2020

Yes I know. I still need to know how we can use submodules.
I will make a test on Parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Development version enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants