Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf Refactor] Optimize the settings screen UI. #63

Open
aakash1313 opened this issue Apr 27, 2020 · 1 comment
Open

[Perf Refactor] Optimize the settings screen UI. #63

aakash1313 opened this issue Apr 27, 2020 · 1 comment

Comments

@aakash1313
Copy link
Collaborator

aakash1313 commented Apr 27, 2020

While trying to add an entry for the language selector in the app, found that this we are using multiple recycler views, we can achieve the same by using less or single recylcer, need to finish this before adding an entry for language settings. This will make it easy to support more entries in future.

@justinklchan
Copy link

Yes this is a good fix to make. If you can just use a single recycler view to represent settings with a Switch, a Dropdown, and a Link. That would be good. Keep in mind that the recycler view used for the settings for switches is also used in the Permissions fragment during onboarding. So make sure all these dependencies still work before pushing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants