Skip to content

Commit 3086e07

Browse files
committed
Issue discussion has been extended for a third bullet
1 parent 4f3dba4 commit 3086e07

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

xml/issue4302.xml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
<discussion>
1212
<p>
1313
The current wording for `vector_sum_of_squares`
14-
<sref ref="[linalg.algs.blas1.ssq]"/> has two problems with its specification of the
14+
<sref ref="[linalg.algs.blas1.ssq]"/> has three problems with its specification of the
1515
value of `result.scaling_factor`.
1616
</p>
1717
<ol>
@@ -28,6 +28,14 @@ division won't help here.</p></li>
2828
so that the scaling factor is no longer necessarily the maximum of the input
2929
scaling factor and the absolute value of all the input elements. It's
3030
a better algorithm and we would like to be able to use it.</p></li>
31+
<li><p>
32+
Both members of <tt>sum_of_squares_result&lt;Scalar&gt;</tt> have the same type,
33+
`Scalar`. If the input `mdspan`'s `value_type` represents a quantity
34+
with units, this would not be correct. For example, if `value_type`
35+
has units of distance (say <tt>[m]</tt>), the sum of squares should have units
36+
of area (<tt>[m<sup>2</sup>]</tt>), while the scaling factor should have units of
37+
distance (<tt>[m]</tt>).
38+
</p></li>
3139
</ol>
3240
<p>
3341
Problem (1) means that the current wording is broken. I suggest two

0 commit comments

Comments
 (0)