File tree Expand file tree Collapse file tree 1 file changed +9
-1
lines changed Expand file tree Collapse file tree 1 file changed +9
-1
lines changed Original file line number Diff line number Diff line change 11
11
<discussion >
12
12
<p >
13
13
The current wording for `vector_sum_of_squares`
14
- <sref ref =" [linalg.algs.blas1.ssq]" /> has two problems with its specification of the
14
+ <sref ref =" [linalg.algs.blas1.ssq]" /> has three problems with its specification of the
15
15
value of `result.scaling_factor`.
16
16
</p >
17
17
<ol >
@@ -28,6 +28,14 @@ division won't help here.</p></li>
28
28
so that the scaling factor is no longer necessarily the maximum of the input
29
29
scaling factor and the absolute value of all the input elements. It's
30
30
a better algorithm and we would like to be able to use it.</p ></li >
31
+ <li ><p >
32
+ Both members of <tt >sum_of_squares_result< Scalar> </tt > have the same type,
33
+ `Scalar`. If the input `mdspan`'s `value_type` represents a quantity
34
+ with units, this would not be correct. For example, if `value_type`
35
+ has units of distance (say <tt >[m]</tt >), the sum of squares should have units
36
+ of area (<tt >[m<sup >2</sup >]</tt >), while the scaling factor should have units of
37
+ distance (<tt >[m]</tt >).
38
+ </p ></li >
31
39
</ol >
32
40
<p >
33
41
Problem (1) means that the current wording is broken. I suggest two
You can’t perform that action at this time.
0 commit comments