Skip to content

Commit 31be614

Browse files
committed
Remove unused scheduler_op::data_ and data()
1 parent fbe2500 commit 31be614

5 files changed

Lines changed: 4 additions & 32 deletions

File tree

‎src/corosio/src/detail/epoll/op.hpp‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -149,10 +149,7 @@ struct epoll_op : scheduler_op
149149
epoll_socket_impl* socket_impl_ = nullptr;
150150
epoll_acceptor_impl* acceptor_impl_ = nullptr;
151151

152-
epoll_op()
153-
{
154-
data_ = this;
155-
}
152+
epoll_op() = default;
156153

157154
void reset() noexcept
158155
{

‎src/corosio/src/detail/iocp/overlapped_op.hpp‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,6 @@ struct overlapped_op
7575
explicit overlapped_op(func_type func) noexcept
7676
: scheduler_op(func)
7777
{
78-
data_ = this;
7978
reset_overlapped();
8079
}
8180

‎src/corosio/src/detail/posix/resolver_service.cpp‎

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -324,10 +324,7 @@ class posix_resolver_impl
324324
std::atomic<bool> cancelled{false};
325325
std::optional<std::stop_callback<canceller>> stop_cb;
326326

327-
resolve_op()
328-
{
329-
data_ = this;
330-
}
327+
resolve_op() = default;
331328

332329
void reset() noexcept;
333330
void operator()() override;
@@ -370,10 +367,7 @@ class posix_resolver_impl
370367
std::atomic<bool> cancelled{false};
371368
std::optional<std::stop_callback<canceller>> stop_cb;
372369

373-
reverse_resolve_op()
374-
{
375-
data_ = this;
376-
}
370+
reverse_resolve_op() = default;
377371

378372
void reset() noexcept;
379373
void operator()() override;

‎src/corosio/src/detail/scheduler_op.hpp‎

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@
1818

1919
namespace boost::corosio::detail {
2020

21-
class win_scheduler;
22-
2321
/** Base class for completion handlers using function pointer dispatch.
2422
2523
Handlers are continuations that execute after an asynchronous
@@ -95,18 +93,6 @@ class scheduler_op : public intrusive_queue<scheduler_op>::node
9593
func_(nullptr, this, 0, 0);
9694
}
9795

98-
/** Returns the user-defined data pointer.
99-
100-
Derived classes may set this to store auxiliary data
101-
such as a pointer to the most-derived object.
102-
103-
@return The user-defined data pointer, or `nullptr` if not set.
104-
*/
105-
void* data() const noexcept
106-
{
107-
return data_;
108-
}
109-
11096
virtual ~scheduler_op() = default;
11197

11298
protected:
@@ -131,7 +117,6 @@ class scheduler_op : public intrusive_queue<scheduler_op>::node
131117
}
132118

133119
func_type func_;
134-
void* data_ = nullptr;
135120
};
136121

137122
//------------------------------------------------------------------------------

‎src/corosio/src/detail/select/op.hpp‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -134,10 +134,7 @@ struct select_op : scheduler_op
134134
select_socket_impl* socket_impl_ = nullptr;
135135
select_acceptor_impl* acceptor_impl_ = nullptr;
136136

137-
select_op()
138-
{
139-
data_ = this;
140-
}
137+
select_op() = default;
141138

142139
void reset() noexcept
143140
{

0 commit comments

Comments
 (0)