Commit 4b952ec
committed
refactor: move make_local_*_pair to test-only header
The public make_local_stream_pair / make_local_datagram_pair were
primarily used to construct test fixtures; production callers exist
in theory but are vanishingly rare compared to test and benchmark
usage. PR #252's Windows implementation was specifically motivated
by tests on IOCP.
Move both helpers into include/boost/corosio/test/local_socket_pair.hpp
under boost::corosio::test, alongside the existing templated stream
variant that the perf benchmarks already use. The test/ helper drives
bind+accept+connect via the public acceptor API, which works on every
backend after PR #252 enabled AF_UNIX SOCK_STREAM on Windows IOCP --
so the bespoke socketpair-emulation Windows code in
src/corosio/src/local_socket_pair.cpp is no longer needed.
- Delete include/boost/corosio/local_socket_pair.hpp
- Delete src/corosio/src/local_socket_pair.cpp
- Remove the umbrella include in boost/corosio.hpp
- Add make_local_datagram_pair to test/local_socket_pair.hpp (POSIX-only)
- Migrate the three test files that called the public helpers
(local_stream_socket.cpp, local_datagram_socket.cpp, reactor_paths.cpp)
via using-declarations so call sites stay identical1 parent d224941 commit 4b952ec
7 files changed
Lines changed: 109 additions & 332 deletions
File tree
- include/boost
- corosio
- test
- src/corosio/src
- test/unit
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
38 | | - | |
39 | 38 | | |
40 | 39 | | |
41 | 40 | | |
| |||
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
13 | 14 | | |
14 | 15 | | |
15 | 16 | | |
16 | 17 | | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
17 | 23 | | |
18 | 24 | | |
19 | 25 | | |
| |||
29 | 35 | | |
30 | 36 | | |
31 | 37 | | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
37 | 42 | | |
38 | 43 | | |
39 | 44 | | |
| |||
137 | 142 | | |
138 | 143 | | |
139 | 144 | | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
140 | 231 | | |
141 | 232 | | |
142 | 233 | | |
0 commit comments