fix bug caused by MacroModel #1225
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- a week ago, MacroModel want to merge a huge pr, which edited here
I have no idea why he did this change, or simply a bug-scanner ai reported this "problem"
- Following error messages just to prove why this patch exists:
In file included from ..\include/fast_io/fast_io.h:10:
In file included from ..\include/fast_io/fast_io_hosted.h:69:
In file included from ..\include/fast_io/fast_io_hosted/platforms/native.h:3:
In file included from ..\include/fast_io/fast_io_hosted/platforms/native_base.h:27:
In file included from ..\include/fast_io/fast_io_hosted/platforms/posix.h:46:
..\include/fast_io/fast_io_hosted/platforms/systemcall_details.h:34:3: error: no member named 'dup' in the global namespace; did you mean simply 'dup'?
34 | ::dup
| ^~~~~
| dup
..\include/fast_io/fast_io_hosted/platforms/systemcall_details.h:11:12: note: 'dup' declared here
11 | inline int dup(int) noexcept
| ^
1 error generated.
Author
|
@trcrsired review plz |
Merged
Collaborator
|
这个dup的本意是用全局函数，而非已有的fast_io::details::dup 已经是noexcept的符号函数。_dup还是得全局的 |
Author
但是编译也没通过啊，而且下面的都没有加上::从全局进行调用 |
Collaborator
我改了个新的 |
Collaborator
因为你这么改也不对，相当于noexcept call 已有的 自定义extern noexcept符号，（dos环境） |
Author
我是在交叉到wasip1的时候出的问题，你的patch也没解决这个问题 |
Author
|
行，@MacroModel 确实修掉了，那我就关闭这个pr了 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In file included from ..\include/fast_io/fast_io.h:10: In file included from ..\include/fast_io/fast_io_hosted.h:69: In file included from ..\include/fast_io/fast_io_hosted/platforms/native.h:3: In file included from ..\include/fast_io/fast_io_hosted/platforms/native_base.h:27: In file included from ..\include/fast_io/fast_io_hosted/platforms/posix.h:46: ..\include/fast_io/fast_io_hosted/platforms/systemcall_details.h:34:3: error: no member named 'dup' in the global namespace; did you mean simply 'dup'?
34 | ::dup
| ^~~~~
| dup
..\include/fast_io/fast_io_hosted/platforms/systemcall_details.h:11:12: note: 'dup' declared here
11 | inline int dup(int) noexcept
| ^
1 error generated.