fix api usage

Author: Tsche

runtime/src/api/client.ts

@@ -168,7 +168,22 @@ export class FeedbackClient {
     url.searchParams.set("key", key);
     const init: RequestInit = { headers: { Accept: "application/json" } };
     if (signal) init.signal = signal;
-    const response = await this.#fetch(url, init);
+    let response = await this.#fetch(url, init);
+    if (response.status === 400 && await errorCode(response.clone()) === "invalid_keys") {
+      // Older deployed APIs use `keys`; send only this one key during rollout.
+      url.searchParams.delete("key");
+      url.searchParams.set("keys", key);
+      response = await this.#fetch(url, init);
+      if (!response.ok) throw new FeedbackError(response.status, await errorCode(response));
+      const legacy: unknown = await response.json();
+      const items = legacy && typeof legacy === "object" ? (legacy as { items?: unknown }).items : undefined;
+      const discussion = items && typeof items === "object"
+        ? (items as Record<string, unknown>)[key] : undefined;
+      if (!discussion || typeof discussion !== "object" || Array.isArray(discussion)) {
+        throw new TypeError("Invalid discussion content response");
+      }
+      return { discussion: discussion as Record<string, unknown>, comments: [] };
+    }
     if (!response.ok) throw new FeedbackError(response.status, await errorCode(response));
     const payload: unknown = await response.json();
     if (!payload || typeof payload !== "object" || (payload as { v?: unknown }).v !== 1) {

runtime/test/client.test.ts

@@ -37,6 +37,26 @@ void test("discussion content requests exactly one key", async () => {
   assert.equal(content.discussion.id, "D_example");
 });
 
+void test("discussion content uses one-key legacy request while an older API is deployed", async () => {
+  const requested: string[] = [];
+  const fetch = (input: URL | RequestInfo): Promise<Response> => {
+    const url = input instanceof Request ? input.url : input.toString();
+    requested.push(url);
+    return Promise.resolve(url.includes("?key=")
+      ? Response.json({ v: 1, error: { code: "invalid_keys", message: "keys required" } }, { status: 400 })
+      : Response.json({ v: 1, items: { "feedback/example": { id: "D_example" } } }));
+  };
+  const client = new FeedbackClient({ apiOrigin: "https://feedback-api.cpp.social", site: "cpp-social", fetch });
+
+  const content = await client.discussionContent("feedback/example");
+
+  assert.equal(content.discussion.id, "D_example");
+  assert.deepEqual(requested, [
+    "https://feedback-api.cpp.social/v1/sites/cpp-social/discussion?key=feedback%2Fexample",
+    "https://feedback-api.cpp.social/v1/sites/cpp-social/discussion?keys=feedback%2Fexample",
+  ]);
+});
+
 void test("OAuth transport sends JSON only to the configured site", async () => {
   const requests: Request[] = [];
   const fetch = (input: URL | RequestInfo, init?: RequestInit): Promise<Response> => {