forked from ThreeTen/threetenbp
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scala.js source maps are pointing to unpublished generated sources #519
Comments
I'm sorry too hear that, I'd be happy too accept a PR if you find a fix |
raquo
added a commit
to raquo/scala-java-time
that referenced
this issue
Mar 22, 2025
raquo
added a commit
to raquo/scala-java-time
that referenced
this issue
Mar 22, 2025
raquo
added a commit
to raquo/scala-java-time
that referenced
this issue
Mar 22, 2025
This was referenced Mar 22, 2025
cquiroz
added a commit
that referenced
this issue
Mar 23, 2025
Fix source map URLs (as much as possible). Fixes #519
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello,
The Scala.js source maps should point to the corresponding file on
raw.githubusercontent.com
containing the corresponding file content.For example, the source map url for
ZoneRulesProvider.scala
should* point tohttps://raw.githubusercontent.com/cquiroz/scala-java-time/v2.6.0/core/shared/src/main/scala/org/threeten/bp/zone/ZoneRulesProvider.scala
, however currently the published source maps for this file are pointing tohttps://raw.githubusercontent.com/cquiroz/scala-java-time/v2.6.0/core/js/target/scala-3.3.3/src_managed/main/org/threeten/bp/zone/ZoneRulesProvider.scala
which does not exist.* Assuming that the files are copied into
target
without modification. If there are source modifications during that copy, then the issue becomes more complicated.This source mapping feature was first raised in #25 and fully implemented in #32. It's likely that moving to sbt-typelevel in #418 broke this, as that is when the code from #32 was removed.
ETA: As for how to test the correctness of the paths – the
sjsir
files in the published artifact are binary, but contain these paths as plain strings, so you can view them e.g. in IntelliJ under "external libraries" in the project / file tree, when loading the library from another intellij project. IDE may need a restart / reload when updating the publishLocal-ed version to see the changes.The text was updated successfully, but these errors were encountered: