issues graphite 1.1.5 and "local" finder

[Roguelazer]

The biggraphite graphite finder is marked as non-local (with the class attribute local=False); as of graphite 1.1.5, if you're using graphite in clustered mode, the frontend sends the local=1 parameter on remote find requests and thus can't ever see anything from biggraphite.

Practically, this means that when I upgraded my frontends from 1.1.4 to 1.1.5, they stopped seeing biggraphite data. I applied the following patch to fix it:

diff --git a/biggraphite/plugins/graphite.py b/biggraphite/plugins/graphite.py
index e5d6c1a..d8821be 100755
--- a/biggraphite/plugins/graphite.py
+++ b/biggraphite/plugins/graphite.py
@@ -261,7 +261,7 @@ class Reader(BaseReader):
 class Finder(BaseFinder):
     """Finder plugin for BigGraphite."""

-    local = False
+    local = True

     def __init__(
         self, directories=None, accessor=None, metadata_cache=None, carbonlink=None

I actually can't find where in the 1.1.4 to 1.1.5 transition the local=1 flag started getting set, but it worked before and doesn't work now, so shrug.

If you're curious, the architecture looks something like

[adriengentil]

Hello,

Thanks for your report. I'll take a look in the coming days.

Adrien

[david-guenault]

Not sure this is the same problem, but we found that it was impossible to "federate" two graphite clusters with graphite web because of local=1. The only workaround was to modify code in graphite web the following way.

• Edit webapp/graphite/finders/remote.py and modify each occurence of ('local', '1') by ('local', '0'). This will give you access to federated metrics tree in graphite web.

• Edit webapp/graphite/readers/remote.py replace each occurence of ('local', '1') by ('local', '0'). This will give you access to federated metric renders in graphite web.

[iksaif]

Could you send a PR ?

[david-guenault]

No the modification is only for graphite part. So out of scope for biggraphite. Sorry