You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix compatibility issue with URL attachments wrong number of arguments (#250)
- Fix ArgumentError: wrong number of arguments (given 2, expected 0..1)
that occurs when Marcel processes URI objects
- Use filename-based MIME detection for URLs instead of passing URI
objects to Marcel
- Add test that reproduces the issue and validates the fix
- Maintains backward compatibility and improves performance by avoiding
network calls
<img width="1316" alt="Screenshot 2025-06-16 at 9 34 13 AM"
src="https://github.com/user-attachments/assets/b0d29eeb-66aa-45b5-aed9-5c33adf0c0b7"
/>
## What this does
<!-- Clear description of what this PR does and why -->
## Type of change
- [x] Bug fix
- [ ] New feature
- [ ] Breaking change
- [ ] Documentation
- [ ] Performance improvement
## Scope check
- [x] I read the [Contributing
Guide](https://github.com/crmne/ruby_llm/blob/main/CONTRIBUTING.md)
- [x] This aligns with RubyLLM's focus on **LLM communication**
- [x] This isn't application-specific logic that belongs in user code
- [x] This benefits most users, not just my specific use case
## Quality check
- [x] I ran `overcommit --install` and all hooks pass
- [x] I tested my changes thoroughly
- [ ] I updated documentation if needed
- [x] I didn't modify auto-generated files manually (`models.json`,
`aliases.json`)
## API changes
- [ ] Breaking change
- [ ] New public methods/classes
- [ ] Changed method signatures
- [x] No API changes
## Related issues
Fixes#247
---------
Co-authored-by: Carmine Paolino <[email protected]>
0 commit comments