Skip to content

Commit 0ed783f

Browse files
committed
Wrap Statement and ResultSet in try-with-resource blocks
1 parent 6890842 commit 0ed783f

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

src/main/java/de/cronn/liquibase/ext/postgres/ModifyPostgresEnumTypeChange.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import java.sql.ResultSet;
44
import java.sql.SQLException;
5+
import java.sql.Statement;
56
import java.util.ArrayList;
67
import java.util.Arrays;
78
import java.util.List;
@@ -95,9 +96,9 @@ public SqlStatement[] generateStatements(Database database) {
9596
statements.addAll(Arrays.asList(createPostgresEnumTypeChange.generateStatements(database)));
9697

9798
JdbcConnection jdbcConnection = (JdbcConnection) database.getConnection();
98-
try {
99-
String defaultSchemaName = database.getDefaultSchemaName();
100-
ResultSet resultSet = jdbcConnection.createStatement().executeQuery(SELECT_ALL_ENUM_USAGES_QUERY.formatted(defaultSchemaName, getName()));
99+
String defaultSchemaName = database.getDefaultSchemaName();
100+
try (Statement statement = jdbcConnection.createStatement();
101+
ResultSet resultSet = statement.executeQuery(SELECT_ALL_ENUM_USAGES_QUERY.formatted(defaultSchemaName, getName()))) {
101102
while (resultSet.next()) {
102103
String tableName = resultSet.getString("table_name");
103104
String columnName = resultSet.getString("column_name");

src/main/java/de/cronn/liquibase/ext/postgres/diff/PostgresEnumTypeSnapshotGenerator.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import java.sql.Array;
44
import java.sql.ResultSet;
55
import java.sql.SQLException;
6+
import java.sql.Statement;
67
import java.util.List;
78
import java.util.stream.Stream;
89

@@ -41,11 +42,10 @@ protected void addTo(DatabaseObject foundObject, DatabaseSnapshot snapshot) thro
4142
return;
4243
}
4344
if (snapshot.getDatabase().getConnection() instanceof JdbcConnection jdbcConnection) {
44-
try {
45-
Schema schema = foundObject.getSchema();
46-
String schemaName = schema.getName();
47-
ResultSet resultSet = jdbcConnection.createStatement().executeQuery(COLLECT_ENUMS_QUERY.formatted(schemaName));
48-
45+
Schema schema = foundObject.getSchema();
46+
String schemaName = schema.getName();
47+
try (Statement statement = jdbcConnection.createStatement();
48+
ResultSet resultSet = statement.executeQuery(COLLECT_ENUMS_QUERY.formatted(schemaName))) {
4949
while (resultSet.next()) {
5050
String typeName = resultSet.getString("name");
5151
List<String> values = collectValues(resultSet.getArray("values"));

0 commit comments

Comments
 (0)