crowbar: do a graceful shutdown/reboot when invoked via crowbar (bsc#1047636) #1271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
(untested) |
(bsc#1047636) Currently there is a hard reboot executed which is interrupting a currently pending chef-client run. Normally that shouldn't be a problem but in the HA cluster case it can cause significant harm.
dirkmueller
force-pushed
the
graceful_reboot
branch
from
99fd9c2 to
e8243b8
Compare
dirkmueller
changed the title
nicolasbock
approved these changes
Jul 18, 2017
Contributor
nicolasbock
left a comment
nicolasbock
left a comment
There was a problem hiding this comment.
Looks good, but a test would be good :)
| net_rpc_cmd(:power_cycle) | ||
| else | ||
| ssh_cmd("/sbin/reboot") | ||
| ssh_cmd("/usr/sbin/crowbar_join --stop || /sbin/reboot") |
Contributor
There was a problem hiding this comment.
Why not use systemd here?
Contributor
Author
There was a problem hiding this comment.
how does systemd help with reboot? is there a reboot command with systemd?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is a hard reboot executed which is interrupting
a currently pending chef-client run. Normally that shouldn't be
a problem but in the HA cluster case it can cause significant harm.