Skip to content

fix(core): update content type to 'sequence' when Field changes to complex datatype. Fix of #144 #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
germiBest wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(core): update content type to 'sequence' when Field changes to complex datatype. Fix of #144 #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions hl7apy/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -919,6 +919,7 @@ def _set_datatype(self, datatype):
datatype not in ('varies', None, self.datatype) and self.datatype is not None:
reference = load_reference(datatype, 'Datatypes_Structs', self.version)
new_ref = [ref_item for ref_item in self.reference]
new_ref[0] = 'sequence'
new_ref[1] = reference
new_ref[2] = datatype
structure = ElementFinder.get_structure(self, new_ref)
Expand Down
10 changes: 10 additions & 0 deletions tests/test_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1305,6 +1305,16 @@ def test_field_wgith_three_part_name_bug_39(self):
self.assertEqual(f.cm_msg_1.value, 'SIU')
self.assertEqual(f.cm_msg_2.value, 'S12')

def test_field_datatype_to_complex_serialization(self):
f = Field('OBX_5')
f.datatype = 'ED'
f.ed_1 = ''
f.ed_2 = 'IM'
f.ed_3 = 'JPEG'
f.ed_4 = 'Base64'
f.ed_5 = 'SomeData'
self.assertEqual(f.to_er7(), '^IM^JPEG^Base64^SomeData')


class TestComponent(unittest.TestCase):

Expand Down