code cleanup

Author: mindmonk

backend/src/main/java/org/cryptomator/hub/api/AuthorityDto.java

@@ -33,7 +33,7 @@ protected AuthorityDto(String id, Type type, String name, String pictureUrl) {
 	}
 
 	@Inject
-	static User.Repository userRepo; // Inject User Repository für die neue Berechnung
+	static User.Repository userRepo;
 
 	static AuthorityDto fromEntity(Authority a) {
 		return switch (a) {

backend/src/main/java/org/cryptomator/hub/api/AuthorityResource.java

@@ -25,7 +25,7 @@ public class AuthorityResource {
 	Authority.Repository authorityRepo;
 
 	@Inject
-	User.Repository userRepo; // UserRepo wird hier für die Gruppen-Mitgliederanzahl benötigt
+	User.Repository userRepo;
 
 	@GET
 	@Path("/search")
@@ -36,7 +36,7 @@ public class AuthorityResource {
 	public List<AuthorityDto> search(@QueryParam("query") @NotBlank String query) {
 		List<Authority> authorities = authorityRepo.byName(query).toList(); 
 		return authorities.stream()
-			.map(this::convertToDto) // Neue Methode für die Konvertierung mit Member-Anzahl
+			.map(this::convertToDto)
 			.toList();
 	}
 
@@ -49,14 +49,10 @@ public List<AuthorityDto> search(@QueryParam("query") @NotBlank String query) {
 	@APIResponse(responseCode = "200")
 	public List<AuthorityDto> getSome(@QueryParam("ids") List<String> authorityIds) {
 		return authorityRepo.findAllInList(authorityIds)
-			.map(this::convertToDto) // Neue Methode wird hier genutzt
+			.map(this::convertToDto)
 			.toList();
 	}
 
-	/**
-	 * Konvertiert eine Authority-Entity in das passende DTO,
-	 * inklusive der Gruppen-Mitgliederanzahl für Gruppen.
-	 */
 	private AuthorityDto convertToDto(Authority a) {
 		if (a instanceof User u) {
 			return UserDto.justPublicInfo(u);

backend/src/main/java/org/cryptomator/hub/api/GroupsResource.java

@@ -2,21 +2,20 @@
 
 import jakarta.annotation.security.RolesAllowed;
 import jakarta.inject.Inject;
+import jakarta.ws.rs.core.Response;
 import jakarta.ws.rs.GET;
 import jakarta.ws.rs.Path;
 import jakarta.ws.rs.PathParam;
 import jakarta.ws.rs.Produces;
 import jakarta.ws.rs.core.MediaType;
-
 import org.cryptomator.hub.entities.Group;
 import org.cryptomator.hub.entities.User;
 import org.cryptomator.hub.validation.ValidId;
 import org.eclipse.microprofile.openapi.annotations.Operation;
 
-import jakarta.ws.rs.core.Response;
-import java.util.Map;
-import java.util.HashMap;
 import java.util.List;
+import java.util.HashMap;
+import java.util.Map;
 
 @Path("/groups")
 public class GroupsResource {

backend/src/main/java/org/cryptomator/hub/entities/Group.java

@@ -13,7 +13,7 @@
 @DiscriminatorValue("GROUP")
 public class Group extends Authority {
 
-	@ManyToMany(cascade = {CascadeType.REMOVE}, fetch = FetchType.LAZY)
+	@ManyToMany(cascade = {CascadeType.REMOVE})
 	@JoinTable(name = "group_membership",
 			joinColumns = @JoinColumn(name = "group_id", referencedColumnName = "id"),
 			inverseJoinColumns = @JoinColumn(name = "member_id", referencedColumnName = "id")
@@ -31,14 +31,12 @@ public void setMembers(Set<Authority> members) {
 		this.members = members;
 	}
 
-
 	public int getMemberCount() {
-		return groupRepo.countMembers(this.getId()); // Verwende das injectete Repository
+		return groupRepo.countMembers(this.getId());
 	}
 
 	@ApplicationScoped
 	public static class Repository implements PanacheRepositoryBase<Group, String> {
-
 		public int countMembers(String groupId) {
 			return getEntityManager()
 					.createQuery("SELECT SIZE(g.members) FROM Group g WHERE g.id = :groupId", Integer.class)

frontend/src/components/SearchInputGroup.vue

@@ -5,7 +5,7 @@
         <div class="relative">
           <div class="absolute inset-y-0 left-0 pl-3 flex items-center pointer-events-none">
             <UsersIcon v-if="selectedItem == null" class="h-5 w-5 text-gray-400" aria-hidden="true" />
-            <img v-else :src="selectedItem.pictureUrl ?? ''" alt="" class="w-5 h-5 rounded-full">
+            <img v-else :src="selectedItem.pictureUrl ?? ''" alt="" class="w-5 h-5 rounded-full" >
           </div>
 
           <ComboboxInput 

frontend/src/components/VaultDetails.vue

@@ -347,7 +347,6 @@ const groupMemberCounts = computed(() => {
     return counts;
 });
 
-
 async function loadVaultKeys(vaultKeyJwe: string): Promise<VaultKeys> {
   const userKeys = await userdata.decryptUserKeysWithBrowser();
   return VaultKeys.decryptWithUserKey(vaultKeyJwe, userKeys.ecdhKeyPair.privateKey);
@@ -496,17 +495,8 @@ function refreshVault(updatedVault: VaultDto) {
   emit('vaultUpdated', updatedVault);
 }
 
-const searchQuery = ref('');
 const searchResults = ref<Array<AuthorityDto & { memberCount?: number }>>([]);
 
-async function onSearch() {
-  if (!searchQuery.value) {
-    searchResults.value = [];
-    return;
-  }
-  searchResults.value = await searchAuthority(searchQuery.value);
-}
-
 async function searchAuthority(query: string): Promise<(AuthorityDto & { memberCount?: number })[]> {
   const results = await backend.authorities.search(query);
   const filtered = results.filter(authority => !members.value.has(authority.id));
@@ -527,16 +517,6 @@ async function searchAuthority(query: string): Promise<(AuthorityDto & { memberC
   return enhanced.sort((a, b) => a.name.localeCompare(b.name));
 }
 
-const searchGroupMemberCounts = computed(() => {
-  const counts = new Map<string, number>();
-  searchResults.value.forEach((result) => {
-    if (result.type === 'GROUP') {
-      counts.set(result.id, result.memberCount ?? 0);
-    }
-  });
-  return counts;
-});
-
 async function updateMemberRole(member: MemberDto, role: VaultRole) {
   delete onUpdateVaultMembershipError.value[member.id];
   try {