Skip to content

Commit f5e78f2

Browse files
SailRealiammajid
andcommitted
Apply suggestions from code review
Co-authored-by: iammajid <[email protected]>
1 parent f47ed9c commit f5e78f2

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

backend/src/main/java/org/cryptomator/hub/api/VaultResource.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,7 @@ public Response legacyUnlock(@PathParam("vaultId") UUID vaultId, @PathParam("dev
281281
if (accessTokenSeats > license.getSeats()) {
282282
throw new PaymentRequiredException("Number of effective vault users exceeds available license seats");
283283
}
284-
var ipAddress = request.remoteAddress().toString();
284+
var ipAddress = request.remoteAddress().hostAddress();
285285
try {
286286
var access = legacyAccessTokenRepo.unlock(vaultId, deviceId, jwt.getSubject());
287287
eventLogger.logVaultKeyRetrieved(jwt.getSubject(), vaultId, VaultKeyRetrievedEvent.Result.SUCCESS, ipAddress, deviceId);
@@ -322,7 +322,7 @@ public Response unlock(@PathParam("vaultId") UUID vaultId, @QueryParam("evenIfAr
322322
if (user.getEcdhPublicKey() == null) {
323323
throw new ActionRequiredException("User account not initialized.");
324324
}
325-
var ipAddress = request.remoteAddress().host();
325+
var ipAddress = request.remoteAddress().hostAddress();
326326
var deviceId = request.getHeader("Hub-Device-ID");
327327
var access = accessTokenRepo.unlock(vaultId, jwt.getSubject());
328328
if (access != null) {

frontend/src/components/DeviceList.vue

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
</div>
3838
</span>
3939
</th>
40-
<th scope="col" class="px-6 py-3 text-left text-xs font-medium text-gray-500 uppercase tracking-wider whitespace-nowrap" :title="t('deviceList.ipaAddress.toolTip')">
40+
<th scope="col" class="px-6 py-3 text-left text-xs font-medium text-gray-500 uppercase tracking-wider whitespace-nowrap" :title="t('deviceList.ipAddress.toolTip')">
4141
<span class="inline-flex items-center gap-1">
4242
{{ t('deviceList.ipAddress') }}
4343
<span class="relative group">

frontend/src/i18n/en-US.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@
144144
"deviceList.added": "Added",
145145
"deviceList.thisDevice": "This Device",
146146
"deviceList.ipAddress": "IP Address",
147-
"deviceList.ipaAddress.toolTip": "May not be set for legacy reasons.",
147+
"deviceList.ipAddress.toolTip": "May not be set for legacy reasons.",
148148
"deviceList.lastAccess": "Last Access",
149149
"deviceList.lastAccess.toolTip": "May not be set for legacy reasons.",
150150

0 commit comments

Comments
 (0)