switch to ruff and upgrade bandit

Author: Jens Kürten

.gitignore

@@ -9,3 +9,4 @@ venv/
 dist/
 .pytest_cache
 site/
+.ruff_cache

.pre-commit-config.yaml

@@ -2,25 +2,15 @@
 # See https://pre-commit.com/hooks.html for more hooks
 exclude: ^.*migrations/versions
 repos:
-  - repo: https://github.com/timothycrosley/isort
-    rev: 5.12.0
+  - repo: https://github.com/astral-sh/ruff-pre-commit
+    # Ruff version.
+    rev: v0.7.0
     hooks:
-      - id: isort
-        exclude: ^.*migrations/versions
-        args: [
-          "--line-length=120","--profile=black"
-        ]
-  - repo: https://github.com/ambv/black
-    rev: 23.7.0
-    hooks:
-      - id: black
-
-
-  - repo: https://github.com/PyCQA/flake8
-    rev: 6.1.0
-    hooks:
-      - id: flake8
-        args: [  "--max-line-length=120", "--per-file-ignores=*/__init__.py: F401"]
+      # Run the linter.
+      - id: ruff
+        args: [ --fix ]
+      # Run the formatter.
+      - id: ruff-format
 
   - repo: https://github.com/pre-commit/pre-commit-hooks
     rev: v4.4.0
@@ -39,13 +29,7 @@ repos:
       - id: end-of-file-fixer
       - id: mixed-line-ending
       - id: trailing-whitespace
-  - repo: https://github.com/pycqa/pylint
-    rev: v2.15.7
-    hooks:
-      - id: pylint
-        args: ["--output-format", "parseable", "-d", "W0511", "-j", "4"]
-
   - repo: https://github.com/PyCQA/bandit
-    rev: 1.7.5
+    rev: 1.7.10
     hooks:
       - id: bandit

csfunctions/metadata.py

@@ -13,7 +13,7 @@ def __init__(
         transaction_id: str,
         instance_url: str,
         db_service_url: str | None = None,
-        **kwargs
+        **kwargs,
     ):
         super().__init__(
             app_lang=app_lang,
@@ -23,7 +23,7 @@ def __init__(
             request_datetime=request_datetime,
             transaction_id=transaction_id,
             instance_url=instance_url,
-            **kwargs
+            **kwargs,
         )
 
     app_lang: str = Field(..., description="ISO code of the session language that triggered the webhook.")

csfunctions/objects/briefcase.py

@@ -33,7 +33,7 @@ class Briefcase(BaseObject):
     def link_objects(self, data: "EventData"):
         parts = getattr(data, "parts", None)
         documents = getattr(data, "documents", None)
-        engineering_changes = getattr(data, "engineering_changes")
+        engineering_changes = getattr(data, "engineering_changes", None)
 
         if parts and self.part_ids:
             self._link_parts(parts)

csfunctions/response.py

@@ -20,7 +20,7 @@ def __init__(
         actions: list[Action],
         event_id: str | None = None,
         response_type: Literal[ResponseType.WORKLOAD] | None = None,  # pylint: disable=unused-argument
-        **kwargs
+        **kwargs,
     ):
         event_id = event_id or str(uuid4())
         super().__init__(response_type=ResponseType.WORKLOAD, event_id=event_id, actions=actions, **kwargs)
@@ -36,7 +36,7 @@ def __init__(
         data: dict,
         event_id: str | None = None,
         response_type: Literal[ResponseType.DATA] | None = None,
-        **kwargs  # pylint: disable=unused-argument
+        **kwargs,  # pylint: disable=unused-argument
     ):
         event_id = event_id or str(uuid4())
 
@@ -55,7 +55,7 @@ def __init__(
         trace: str = "",
         event_id: str | None = None,
         response_type: Literal[ResponseType.ERROR] | None = None,  # pylint: disable=unused-argument
-        **kwargs
+        **kwargs,
     ):
         event_id = event_id or str(uuid4())
         super().__init__(
@@ -64,7 +64,7 @@ def __init__(
             message=message,
             error_type=error_type,
             trace=trace,
-            **kwargs
+            **kwargs,
         )
 
     response_type: Literal[ResponseType.ERROR]

pyproject.toml

@@ -31,5 +31,22 @@ requests-mock = "^1.9.0"
 requests-mock = "^1.11.0"
 pytest = "^7.4.0"
 
-[tool.black]
+[tool.ruff]
 line-length = 120
+
+[tool.ruff.lint]
+select = [
+    # pycodestyle
+    "E",
+    "W",
+    # Pyflakes
+    "F",
+    # pyupgrade
+    "UP",
+    # flake8-bugbear
+    "B",
+    # flake8-simplify
+    "SIM",
+    # isort
+    "I",
+]