Skip to content

Load css files via browserify #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
joeybaker opened this issue Aug 20, 2015 · 0 comments
Closed

Load css files via browserify #32

joeybaker opened this issue Aug 20, 2015 · 0 comments

Comments

@joeybaker
Copy link
Contributor

via: #29 (comment)

A thing I've noticed but haven't had time to investigate: css-modulesify outputs no css on subsequent builds with https://github.com/bjoerge/rebundler. I suspect this is because css files aren't being added to the browserify cache because they're required by a custom loader.
joeybaker added a commit to joeybaker/css-modulesify that referenced this issue Sep 11, 2015
@joeybaker
internal: add failing test for re-bundling css-modules#32
e85143e
joeybaker added a commit to joeybaker/css-modulesify that referenced this issue Sep 11, 2015
@joeybaker
fix css-modules#32: ensure caches are persisted
022aace 
Previously, the caches were re-initialized on every plugin
initialization. This caused an incompatibility with other tools like
rebundler or persistify.

This change keeps the original intent of creating caches when the plugin
is initialized, but ensures the process keeps the caches instead of the
plugin instance itself. It’s not really possible to have a cache
conflict since they’re keyed by file.
@joeybaker joeybaker mentioned this issue Sep 11, 2015
Merged
joeybaker added a commit to joeybaker/css-modulesify that referenced this issue Sep 11, 2015
@joeybaker
internal: add failing test for re-bundling css-modules#32
6ff4ef8
joeybaker added a commit to joeybaker/css-modulesify that referenced this issue Sep 11, 2015
@joeybaker
fix css-modules#32: ensure caches are persisted
194a6c6 
Previously, the caches were re-initialized on every plugin
initialization. This caused an incompatibility with other tools like
rebundler or persistify.

This change keeps the original intent of creating caches when the plugin
is initialized, but ensures the process keeps the caches instead of the
plugin instance itself. It’s not really possible to have a cache
conflict since they’re keyed by file.
@joshwnj joshwnj mentioned this issue Nov 19, 2015
Open
@mxl mxl mentioned this issue May 17, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joeybaker