Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for intervention/image:^3.0 #110

Open
sulfo opened this issue Apr 17, 2024 · 5 comments
Open

Support for intervention/image:^3.0 #110

sulfo opened this issue Apr 17, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@sulfo
Copy link

sulfo commented Apr 17, 2024

Hey :)

intervention/image v3 has been out some time now, and v2 is labeled with an end-of-life in their documentation. Are there any plans for adding support for the new version?

I've forked the repo to try fixing it - it works, but I'm not 100% confident the code is clean enough for a PR.
Link to fork with the commit

@ctessier
Copy link
Owner

Hi @sulfo

Thank you very much for letting me know, and opening this issue.
I'll have a look this week, and keep you up to date!

Cheers

@ctessier ctessier added the enhancement New feature or request label Apr 17, 2024
@Ruitjes
Copy link
Contributor

Ruitjes commented Oct 10, 2024

@ctessier did you have time to look at it?

@jneal
Copy link

jneal commented Nov 24, 2024

Hi, any updates on this? I bought you a coffee in the hopes that you can accept this PR.

@ctessier
Copy link
Owner

ctessier commented Dec 1, 2024

Hi @jneal,

Thank you for your contribution, that is much appreciated!

I can't simply accept the changes in the fork provided by @sulfo though, because the latest version of intervention/image introduced more breaking changes than that.

I have been working on a new major version for NovaAdvancedImageField, and I am getting close to a working version.

However, before I release it, I am curious to hear what feature from this new version you are interesting in, and why this upgrade seems to be urgent for you?

Thank you for your help!
Clément

@ctessier ctessier mentioned this issue Dec 1, 2024
9 tasks
@jneal
Copy link

jneal commented Dec 1, 2024

I just need an image cropper plugin that installs in my Nova stack. I tried to install this plugin (which seems to be the best image cropper) but it won't install due to a higher version of intervention/image (3.9.0) in my stack due to Nova CKEditor plugin. I need zero new functionality with this plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants