Skip to content

Commit 7b67d26

Browse files
bardliaogregkh
authored andcommitted
ASoC: SOF: Intel: don't check number of sdw links when set dmic_fixup
[ Upstream commit 56a6772 ] Currently, we assume that the PCH DMIC pins are pin-muxed with SoundWire links. However, we do see a HW design that use PCH DMIC along with 3 SoundWire links. Remove the check now. With this change the PCM DMIC will be presented if it is reported by the BIOS irrespective of whether there are SDW links present or not. Signed-off-by: Bard Liao <[email protected]> Reviewed-by: Ranjani Sridharan <[email protected]> Reviewed-by: Péter Ujfalusi <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Mark Brown <[email protected]> Signed-off-by: Sasha Levin <[email protected]>
1 parent e5c9f8d commit 7b67d26

File tree

1 file changed

+2
-16
lines changed

1 file changed

+2
-16
lines changed

sound/soc/sof/intel/hda.c

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1305,22 +1305,8 @@ struct snd_soc_acpi_mach *hda_machine_select(struct snd_sof_dev *sdev)
13051305
/* report to machine driver if any DMICs are found */
13061306
mach->mach_params.dmic_num = check_dmic_num(sdev);
13071307

1308-
if (sdw_mach_found) {
1309-
/*
1310-
* DMICs use up to 4 pins and are typically pin-muxed with SoundWire
1311-
* link 2 and 3, or link 1 and 2, thus we only try to enable dmics
1312-
* if all conditions are true:
1313-
* a) 2 or fewer links are used by SoundWire
1314-
* b) the NHLT table reports the presence of microphones
1315-
*/
1316-
if (hweight_long(mach->link_mask) <= 2)
1317-
dmic_fixup = true;
1318-
else
1319-
mach->mach_params.dmic_num = 0;
1320-
} else {
1321-
if (mach->tplg_quirk_mask & SND_SOC_ACPI_TPLG_INTEL_DMIC_NUMBER)
1322-
dmic_fixup = true;
1323-
}
1308+
if (sdw_mach_found || mach->tplg_quirk_mask & SND_SOC_ACPI_TPLG_INTEL_DMIC_NUMBER)
1309+
dmic_fixup = true;
13241310

13251311
if (tplg_fixup &&
13261312
dmic_fixup &&

0 commit comments

Comments
 (0)