Skip to content

Commit f571a71

Browse files
committed
arm64: cacheinfo: Avoid out-of-bounds write to cacheinfo array
jira VULN-54130 cve CVE-2025-21785 commit-author Radu Rendec <[email protected]> commit 875d742 The loop that detects/populates cache information already has a bounds check on the array size but does not account for cache levels with separate data/instructions cache. Fix this by incrementing the index for any populated leaf (instead of any populated level). Fixes: 5d425c1 ("arm64: kernel: add support for cpu cache information") Signed-off-by: Radu Rendec <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Will Deacon <[email protected]> (cherry picked from commit 875d742) Signed-off-by: Marcin Wcisło <[email protected]>
1 parent db4466c commit f571a71

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

arch/arm64/kernel/cacheinfo.c

+7-5
Original file line numberDiff line numberDiff line change
@@ -87,16 +87,18 @@ int populate_cache_leaves(unsigned int cpu)
8787
unsigned int level, idx;
8888
enum cache_type type;
8989
struct cpu_cacheinfo *this_cpu_ci = get_cpu_cacheinfo(cpu);
90-
struct cacheinfo *this_leaf = this_cpu_ci->info_list;
90+
struct cacheinfo *infos = this_cpu_ci->info_list;
9191

9292
for (idx = 0, level = 1; level <= this_cpu_ci->num_levels &&
93-
idx < this_cpu_ci->num_leaves; idx++, level++) {
93+
idx < this_cpu_ci->num_leaves; level++) {
9494
type = get_cache_type(level);
9595
if (type == CACHE_TYPE_SEPARATE) {
96-
ci_leaf_init(this_leaf++, CACHE_TYPE_DATA, level);
97-
ci_leaf_init(this_leaf++, CACHE_TYPE_INST, level);
96+
if (idx + 1 >= this_cpu_ci->num_leaves)
97+
break;
98+
ci_leaf_init(&infos[idx++], CACHE_TYPE_DATA, level);
99+
ci_leaf_init(&infos[idx++], CACHE_TYPE_INST, level);
98100
} else {
99-
ci_leaf_init(this_leaf++, type, level);
101+
ci_leaf_init(&infos[idx++], type, level);
100102
}
101103
}
102104
return 0;

0 commit comments

Comments
 (0)