From fa79650bcdf85e3e38cfa03f3ab01b0d86e5782e Mon Sep 17 00:00:00 2001 From: Pratham Patel Date: Thu, 24 Jul 2025 15:34:50 +0530 Subject: [PATCH] i2c: Fix a potential use after free jira VULN-28 cve CVE-2019-25162 commit-author Xu Wang commit e4c72c06c367758a14f227c847f9d623f1994ecf Free the adap structure only after we are done using it. This patch just moves the put_device() down a bit to avoid the use after free. Fixes: 611e12ea0f12 ("i2c: core: manage i2c bus device refcount in i2c_[get|put]_adapter") Signed-off-by: Xu Wang [wsa: added comment to the code, added Fixes tag] Signed-off-by: Wolfram Sang (cherry picked from commit e4c72c06c367758a14f227c847f9d623f1994ecf) Signed-off-by: Pratham Patel --- drivers/i2c/i2c-core-base.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c index b4d0983a23f14..0190a9b73c9c7 100644 --- a/drivers/i2c/i2c-core-base.c +++ b/drivers/i2c/i2c-core-base.c @@ -2328,8 +2328,9 @@ void i2c_put_adapter(struct i2c_adapter *adap) if (!adap) return; - put_device(&adap->dev); module_put(adap->owner); + /* Should be last, otherwise we risk use-after-free with 'adap' */ + put_device(&adap->dev); } EXPORT_SYMBOL(i2c_put_adapter);