From 5050f397e71980032749cafd13b8d22509d0fc5f Mon Sep 17 00:00:00 2001 From: Chris Kin Yat Chan Date: Tue, 11 Aug 2026 11:26:07 +1000 Subject: [PATCH] fix: only notify Slack when a publish was actually attempted Co-Authored-By: Claude --- .github/workflows/changeset.yaml | 26 ++++++++++++++++++-------- 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/.github/workflows/changeset.yaml b/.github/workflows/changeset.yaml index 254bde1a8a2..5d42ed33f1b 100644 --- a/.github/workflows/changeset.yaml +++ b/.github/workflows/changeset.yaml @@ -38,20 +38,30 @@ jobs: published_packages: ${{ steps.changesets.outputs.publishedPackages }} buildkite_webhook_url: ${{ secrets.ENCHIRIDION_BUILDKITE_WEBHOOK_URL }} - notify-slack: + notify-slack-success: runs-on: ubuntu-latest timeout-minutes: 5 - needs: - version - # We only trigger this flow if the publish is happening, inferred by not having a changeset. - if: needs.version.outputs.hasChangesets == 'false' - env: - PUBLISHED: ${{ needs.version.outputs.hasPublished }} + needs: version + if: needs.version.outputs.hasPublished == 'true' + steps: + - name: Send + uses: slackapi/slack-github-action@v1.24.0 + with: + channel-id: 'C02NUQ27G56' + slack-message: 'Packages have been published' + env: + SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }} + + notify-slack-failure: + runs-on: ubuntu-latest + timeout-minutes: 5 + needs: version + if: ${{ always() && needs.version.result == 'failure' }} steps: - name: Send uses: slackapi/slack-github-action@v1.24.0 with: channel-id: 'C02NUQ27G56' - slack-message: ${{ env.PUBLISHED == 'true' && 'Packages have been published' || 'Publishing failed' }} + slack-message: 'Publishing failed' env: SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }}