Skip to content

Commit 019cbf2

Browse files
authored
Remove ambiguous string scope (#1661)
And add notification for when we break it again ## Checklist - [ ] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [ ] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [ ] I have not broken the cheatsheet
1 parent 77a3b55 commit 019cbf2

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

Diff for: cursorless-talon/src/csv_overrides.py

+4
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,10 @@ def update_dicts(
143143
results_map = {}
144144
for list_name, dict in default_values.items():
145145
for key, value in dict.items():
146+
if value in results_map:
147+
warning = f"WARNING: Duplicate value `{value}` in {list_name}.csv"
148+
print(warning)
149+
app.notify(warning)
146150
results_map[value] = {"key": key, "value": value, "list": list_name}
147151

148152
# Update result with current values

Diff for: cursorless-talon/src/modifiers/scopes.py

-1
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@
4646
"-six section": "sectionLevelSix",
4747
"selector": "selector",
4848
"state": "statement",
49-
"string": "string",
5049
"branch": "branch",
5150
"type": "type",
5251
"value": "value",

0 commit comments

Comments
 (0)