[Helm] Fixed export when disableDistinctCachePerService is false (by default) #9008
+23
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpecLad
approved these changes
Jan 29, 2025
2 tasks
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9008 +/- ##
========================================
Coverage 73.39% 73.39%
========================================
Files 415 416 +1
Lines 44192 44198 +6
Branches 3859 3860 +1
========================================
+ Hits 32435 32441 +6
Misses 11757 11757
|
Closed
This was
linked to
issues
Jan 29, 2025
|
will it fix the online version, at cvat.ai ? |
|
@Gabriellgpc , it will, but we need to deploy the fix. Please give us some time. CVAT Online will work as expected already today. |
|
Got it. Thank you for the reply @nmanovic |
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
disableDistinctCachePerServicesetting.Previously this cache was used to cache chunks of data on storage, which is not relevant now.
Currently only events need to be stored before being sent to Vector, and this will always be cached for each service, so these settings are no longer needed.
Motivation and context
How has this been tested?
Checklist
developbranchLicense
Feel free to contact the maintainers if that's a concern.