Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactoring] Refined styles for quality page #9068

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

klakhov
Copy link
Contributor

@klakhov klakhov commented Feb 6, 2025

Motivation and context

This PR refactors the quality page styles, specifically the tables. Currently, the page layout consists of some static elements and a table with dynamic height. If the table is too large, a scrollbar appears.

Previously, the table’s height was limited using max-height: calc(100vh - $grid-unit-size * x);. However, this approach isn’t ideal because, on smaller screens (especially those with a width under 1800px) or when scaling the page, the height needs further adjustments. While media queries could help, they introduce complexity.

This PR updates the layout to use a flexbox-based approach instead. The main page now has display: flex, and the table inside it uses flex-grow: 1 to fill the remaining space dynamically. To make this work, I also flattened the component structure by removing unnecessary containers.

Additionally, I added a media query breakpoint that makes the page scrollable when the width is below 1300px.

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • [ ] I have created a changelog fragment
  • [ ] I have updated the documentation accordingly
  • [ ] I have added tests to cover my changes
  • [ ] I have linked related issues (see GitHub docs)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@klakhov klakhov added the ui/ux label Feb 6, 2025
@klakhov klakhov requested a review from bsekachev as a code owner February 6, 2025 11:13
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.91%. Comparing base (fb3bde4) to head (bd1c5da).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #9068   +/-   ##
========================================
  Coverage    73.91%   73.91%           
========================================
  Files          428      428           
  Lines        44530    44530           
  Branches      3881     3881           
========================================
  Hits         32915    32915           
  Misses       11615    11615           
Components Coverage Δ
cvat-ui 77.44% <ø> (ø)
cvat-server 71.00% <0.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants