**Bug/Method faliure** Get External Poligon for reference face

[adrimg89]

Hello,

I am experiencing an issue with the function get_external_polygon_for_reference_face, and I would like to report it with a simple example.

I have two panels, as shown below.

For each panel, I am adding a node at every vertex returned by this method.

When I apply the method to a panel without circular perforations, it works as expected and returns all the correct vertices.

However, when I apply the same method to a panel with a circular perforation, the behavior seems incorrect. In this case, the returned list only contains a limited set of points, as shown below, instead of the full external polygon.

This leads me to believe that the method may not be handling circular perforations correctly.

Could you please check whether this is the expected behavior or if this might be a bug?

Thank you very much for your help.

[usai-sylvain]

Weird that you get the points on both side of the drilling, looks like the "reference face" has changed from top face to drilling body.
Do we know how the reference face is defined ? can it be set with the API ?

[adrimg89]

Yes, that is exactly the strange behavior I am referring to.

In the images, I am highlighting the reference face (you can see its border using the CTRL+B command) precisely because of this issue.

Even though the correct reference face is clearly selected, the method still returns an incomplete set of points when the panel contains a circular perforation.

For this reason, it looks like the method is failing or not correctly handling this specific case.

[Brunner246]

Hi @adrimg89

Well, that looks like a bug.
i did a quick test with a simple panel.

import cadwork
import element_controller as ec
import geometry_controller as gc

[element_id] = ec.get_active_identifiable_element_ids()

facets = gc.get_element_facets(element_id)
vertices_ref_face = facets.get_external_polygon_for_reference_face()
[ec.create_node(vertex) for vertex in vertices_ref_face]

You could also query the points with following approach.

import cadwork
import element_controller as ec
import geometry_controller as gc

[element_id] = ec.get_active_identifiable_element_ids()

vertices = gc.get_element_reference_face_vertices(element_id)
[ec.create_node(vertex) for vertex in vertices]

[adrimg89]

I am using exactly the same approach to obtain the external polygon, but I am getting a different result than in your first example.

Do you have any idea where the issue could be coming from?
Do you think the problem is related to the reference face selection, the circular perforation, or the method itself?

Thank you!

[Brunner246]

I am using exactly the same approach to obtain the external polygon, but I am getting a different result than in your first example.

Do you have any idea where the issue could be coming from? Do you think the problem is related to the reference face selection, the circular perforation, or the method itself?

Thank you!

could you provide your script (reduced) and a zipped 3d file (reduced to 1-2 elements) ?

[adrimg89]

Sure!

My code is this:

for element in elements:
        print(element.id,element[User_attribute_name.FLOOR])
        facets=gc.get_element_facets(element.id)
        externalpolygon=facets.get_external_polygon_for_reference_face()
        externalpolygon.append(externalpolygon[0])
        
        for point in externalpolygon:
            ec.create_node(point)

I attached the 3d file, too

Thank you!

issue_panel.zip

[usai-sylvain]

Adrian's panel is lying horizontal, Michi's panel is standing upright.
@adrimg89 if you rotate your panel 90° along Y Axis the script is returning the correct points. (I'm not saying you should do that, but that seems to be causing the issue).

@Brunner246 I had to rename the .zip file to .rar to open it.

[usai-sylvain]

I am having similar issue. I have a panel with multiple operations. get_vertices_for_reference_face gives me one of the reference face vertices but arguably there would be more than one reference face to consider.

import cadwork 
import element_controller as ec
import geometry_controller as gc
import attribute_controller as ac
import sys; print(sys.version)


def main():
    elements = ec.get_active_identifiable_element_ids()
    if not elements:
        raise SystemExit("No active identifiable elements.")
    element = elements[0]
    facets = gc.get_element_facets(element)
    # vertices = facets.get_vertices_for_reference_face()
    vertices = facets.get_external_polygon_for_reference_face()

    [ec.create_node(vertex) for vertex in vertices]

if __name__ == "__main__":
    main()

260212_CadworkPanel_ReferenceFace.zip

[Brunner246]

@adrimg89 @usai-sylvain
fixed from build >= 32.0.456

[Brunner246]

@adrimg89 @usai-sylvain fixed from build >= 32.0.456

fixed from build >= 32.0.456

### fixed from build >= 32.0.457

import cadwork
import element_controller as ec
import geometry_controller as gc
import visualization_controller as vc

[element_id] = ec.get_active_identifiable_element_ids()
element_facets = gc.get_element_facets(element_id)

internal_ref_polygon_vertices = (ec.create_node(p) for polygon in element_facets.get_internal_polygons_for_reference_face() for p in polygon)
vc.set_color(internal_ref_polygon_vertices, 5)

external_ref_polygon_vertices = (ec.create_node(p) for p in element_facets.get_external_polygon_for_reference_face())
vc.set_color(external_ref_polygon_vertices, 24)